fix: policycoreutils python package name

[mikaellanger]

I have a few legacy hosts with Centos 7 where trying to install python-policycoreutils fails.

At least in Centos 7 the packages is named policycoreutils-python, and finding no such package here either https://pkgs.org/download/python-policycoreutils

[SuperQ]

Two things. This task is used in several roles, so should update all them.

I also think this is going to be a problem for redhat 8+, since this package has been renamed.

[mikaellanger]

Two things. This task is used in several roles, so should update all them.

You mean the same task is duplicated in more places in this repo? Sure.

I also think this is going to be a problem for redhat 8+, since this package has been renamed.

AFAIK it was renamed from policycoreutils-python to python3-policycoreutils, so I believe it's still fine for redhat 8+?

[SuperQ]

Hmm, I guess if python3 is a good enough signal, it should work.

[gardar]

The definition is present in these files:

ansible/roles/prometheus/vars/main.yml

Lines 12 to 14 in d389ad2

	_prometheus_selinux_packages: "{{ ['libselinux-python', 'python-policycoreutils']
	if ansible_python_version is version('3', '<') else
	['python3-libselinux', 'python3-policycoreutils'] }}"

ansible/roles/alertmanager/tasks/selinux.yml

Lines 4 to 6 in d389ad2

	name: "{{ ['libselinux-python', 'python-policycoreutils']
	if ansible_python_version is version('3', '<') else
	['python3-libselinux', 'python3-policycoreutils'] }}"

ansible/roles/node_exporter/tasks/selinux.yml

Lines 4 to 6 in d389ad2

	name: "{{ ['libselinux-python', 'python-policycoreutils']
	if ansible_python_version is version('3', '<') else
	['python3-libselinux', 'python3-policycoreutils'] }}"

The package change came with python3 on redhat based platforms, that's why I thought the cleanest approach would be to make the conditional work on the python interpreter. (and yes you can blame me for the package name typo - whoops :) )

[mikaellanger]

Changed the other two places.

The package change came with python3 on redhat based platforms, that's why I thought the cleanest approach would be to make the conditional work on the python interpreter.

Based on available packages I agree that seems to be correct, yes.

[gardar]

@mikaellanger please fix sign-off

[SuperQ]

Just need to fix the DCO.

[mikaellanger]

Done