-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add skip_install
variables to various roles
#74
Conversation
Wouldn't it make sense to have |
yes, quite possible |
let me amend the pr with additional |
1dc594c
to
52d323b
Compare
skip_install
variableskip_install
variables to various roles
should be there now |
skip_install
variables to various rolesskip_install
variables to various roles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're not quite there yet, please take a look at the failures in the tests.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
yeah, looks like I messed up one of those conditions. Should be fixed now (and will re-push with my |
do you want me to rebase on top of main? |
Yeah that'd be good |
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download alertmanager binaries Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download blackbox_exporter binary Also, fix a small typo in the preflight task. Signed-off-by: Christian Brabandt <cb@256bit.org>
okay |
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download the mysqld exporter binary Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download the node exporter binary Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download the snmp exporter binary Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download the SystemD exporter binary Signed-off-by: Christian Brabandt <cb@256bit.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download alertmanager binaries
thanks for considering