Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add skip_install variables to various roles #74

Merged
merged 6 commits into from
Mar 26, 2023

Conversation

chrisbra
Copy link
Contributor

This is similar to prometheus_skip_install variable and does what the name says: when set, it won't try to re-download alertmanager binaries

thanks for considering

@gardar
Copy link
Member

gardar commented Mar 16, 2023

Wouldn't it make sense to have skip_install variables for all of the roles?

@chrisbra
Copy link
Contributor Author

yes, quite possible

@chrisbra
Copy link
Contributor Author

let me amend the pr with additional skip_install variables for the other roles.

@chrisbra chrisbra force-pushed the skip_install branch 2 times, most recently from 1dc594c to 52d323b Compare March 20, 2023 15:13
@chrisbra chrisbra changed the title Alertmanager: add skip_install variable enhancements: add skip_install variables to various roles Mar 20, 2023
@chrisbra
Copy link
Contributor Author

should be there now

@gardar gardar changed the title enhancements: add skip_install variables to various roles enhancement: add skip_install variables to various roles Mar 21, 2023
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 21, 2023
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're not quite there yet, please take a look at the failures in the tests.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@chrisbra
Copy link
Contributor Author

yeah, looks like I messed up one of those conditions. Should be fixed now (and will re-push with my Sign-Offed By added

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 21, 2023
@chrisbra
Copy link
Contributor Author

do you want me to rebase on top of main?

@gardar
Copy link
Member

gardar commented Mar 21, 2023

do you want me to rebase on top of main?

Yeah that'd be good

This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download alertmanager binaries

Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download blackbox_exporter
binary

Also, fix a small typo in the preflight task.

Signed-off-by: Christian Brabandt <cb@256bit.org>
@chrisbra
Copy link
Contributor Author

okay

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 21, 2023
This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download the mysqld exporter
binary

Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download the node exporter
binary

Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download the snmp exporter
binary

Signed-off-by: Christian Brabandt <cb@256bit.org>
This is similar to prometheus_skip_install variable and does what the
name says: when set, it won't try to re-download the SystemD exporter
binary

Signed-off-by: Christian Brabandt <cb@256bit.org>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 21, 2023
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gardar gardar requested a review from SuperQ March 22, 2023 11:11
@SuperQ SuperQ merged commit b801a8d into prometheus-community:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants