[prometheus-stackdriver-exporter] Switch exporter config to agrs instead of env variables. #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
monotek
requested changes
Feb 10, 2022
|
@monotek there isn't really any breaking change for users of the chart itself. So I think that an upgrade guide is needed. |
monotek
requested changes
Feb 10, 2022
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
monotek
requested changes
Feb 10, 2022
Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
Signed-off-by: Anas <anas-aso@users.noreply.github.com>
|
@monotek all good now. Thanks for updating the readme. |
monotek
approved these changes
Feb 11, 2022
rpahli
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade app version to 0.12.0 https://github.com/prometheus-community/stackdriver_exporter/releases/tag/v0.12.0
This version comes with a breaking change of dropping env variables config for this exporter: prometheus-community/stackdriver_exporter#142
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
I bumped the chart version to 2.0.0 due to the change in how config is passed to the exporter.
Checklist
[prometheus-couchdb-exporter])