[prometheus-json-exporter] Automatically rollover deployment when configmap changed. #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanhsieh
previously approved these changes
Dec 20, 2022
stefanandres
force-pushed
the
json-exporter-rollover-deployment
branch
from
0f7dacf
to
6c8892a
Compare
stefanandres
requested review from
desaintmartin,
dotdc,
mrueg,
tariq1890 and
a team
as code owners
stefanandres
force-pushed
the
json-exporter-rollover-deployment
branch
2 times, most recently
from
90f0e92
to
6858dc3
Compare
|
Sorry, I wrongly rebased the branch, it's up2date now again. |
monotek
requested changes
Dec 21, 2022
stefanandres
force-pushed
the
json-exporter-rollover-deployment
branch
from
6858dc3
to
8258df5
Compare
monotek
requested changes
Dec 22, 2022
Add annotation to deployment to auto rollover the deployment on changes to the configmap (https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments) Signed-off-by: Stefan Andres <s.andres@syseleven.de>
stefanandres
force-pushed
the
json-exporter-rollover-deployment
branch
from
9870070
to
9518805
Compare
Yeah, that got mixed up the the bogus rebase in the beginning. I hope it's done now, since the Chart is now also 0.6 and not 0.5 anymore ;) |
monotek
approved these changes
Dec 22, 2022
cx-asafd
pushed a commit
to CheckmarxDev/prometheus-helm-charts
that referenced
this pull request
Dec 29, 2022
…-community#2831) Add annotation to deployment to auto rollover the deployment on changes to the configmap (https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments) Signed-off-by: Stefan Andres <s.andres@syseleven.de> Signed-off-by: Stefan Andres <s.andres@syseleven.de>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
May 16, 2023
…-community#2831) Add annotation to deployment to auto rollover the deployment on changes to the configmap (https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments) Signed-off-by: Stefan Andres <s.andres@syseleven.de> Signed-off-by: Stefan Andres <s.andres@syseleven.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add annotation to deployment to auto rollover the deployment on changes to the configmap
(https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments)
Which issue this PR fixes
Currently you need to manually delete the pod to get the new config from the configmap.
Checklist
[prometheus-couchdb-exporter])