[prometheus-blackbox-exporter] allow configurable DNS settings #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig Signed-off-by: John Stewart <jstewart@rentpath.com>
…ent fixes Signed-off-by: John Stewart <jstewart@rentpath.com>
monotek
requested changes
Sep 5, 2020
…ults and version fixes Signed-off-by: John Stewart <jstewart@rentpath.com>
monotek
approved these changes
Sep 6, 2020
|
If I'm thinking this out correctly, @desaintmartin or @gianrubio are the CODEOWNERS for this chart and thus the only ones that can merge this PR in. Mentioning so they see it. Apologies if they see it without being mentioned: I don't know how your workflow works. |
|
Thanks! Edit: hehe, I'm used to the old bot, I just need to figure out how to work here! ;) |
|
@desaintmartin You and @gianrubio should have been invited to the helm-charts-maintainers team. You should have that invite in you inbox. Once you accepta that you should be able to approve this PR. |
|
Hm, I don't see it either from my inbox or from the Github notifications @torstenwalter |
|
@desaintmartin |
desaintmartin
approved these changes
Sep 8, 2020
jstewart612
deleted the
prometheus-blackbox-exporter-dnspolicy-dnsconfig-support
branch
monotek
pushed a commit
to monotek/prometheus-helm-charts
that referenced
this pull request
Oct 7, 2020
…theus-community#42) * [prometheus-blackbox-exporter] allow configurable dnsPolicy and dnsConfig Signed-off-by: John Stewart <jstewart@rentpath.com> * [prometheus-blackbox-exporter] allow configurable DNS settings - nindent fixes Signed-off-by: John Stewart <jstewart@rentpath.com> * [prometheus-blackbox-exporter] allow configurable DNS settings - defaults and version fixes Signed-off-by: John Stewart <jstewart@rentpath.com> Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
junotx
pushed a commit
to junotx/prometheus-helm-charts
that referenced
this pull request
Feb 5, 2024
…etheus-stack [kube-prometheus-stack] add etcd rules and fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Stewart jstewart@rentpath.com