[kube-prometheus-stack] Implement Gateway API #4646
Conversation
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby,
Xtigyro and
a team
as code owners
|
It would be great to see the "ingressPerReplica" feature replicated for this too as we are currently transitioning from Ingress to to Gateway API and have a need to expose each replica externally. |
|
@matzarah could you give feedback what did you think about the current implementation? Once approved, it will be added everywhere including replicas. |
|
Hey @jkroepke I asked for some expects feedback on this and this looks quite good. As long are green, I'm fine with merging this, so can you bump the version? |
jkroepke
force-pushed
the
gateway-api
branch
3 times, most recently
from
7dc8f19
to
83e34ea
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
charts/kube-prometheus-stack/ci/05-ingress-and-gateway-routes-values.yaml
Show resolved
Hide resolved
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
|
Nice work :) |
|
I looked into the per-replica route, but It's a bit too complex for now. I would suggest doing that in a different PR by an user which has more time. |
|
I also need an approval from @GMartinez-Sisti Since this PR contains modifications to the CI job. |
|
Follow-up tasks:
|
| # Be aware that this is an early beta of this feature, | ||
| # kube-prometheus-stack does not guarantee this works and is subject to change. | ||
| # Being BETA this can/will change in the future without notice, do not use unless you want to take that risk | ||
| # [[ref]](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1alpha2) |
There was a problem hiding this comment.
Ref should link to up-to-date docs https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io%2fv1
What this PR does / why we need it
The current template is just an approach. Once finalized, we add it anywhere in the chart.
Ref: #4622
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])