Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube-prometheus-stack] Add downward compat for Prom CRD #4818

Merged
merged 16 commits into from
Sep 26, 2024
Merged

[kube-prometheus-stack] Add downward compat for Prom CRD #4818

merged 16 commits into from
Sep 26, 2024

Commits on Aug 28, 2024

  1. [kube-prometheus-stack] Add downward compatibility for Prometheus CRD… 

    … CRD fields

Running the latest prom-stack versions on legacy OpenShift clusters with no influence on the preinstalled CRDs results in errors such as this:

failed to create typed patch object (..): .spec.scrapeConfigNamespaceSelector: field not declared in schema

This patch provides a workaround using this values.yaml:

prometheus:
  prometheusSpec:
    scrapeConfigNamespaceSelector: null
    scrapeConfigSelectorNilUsesHelmValues: null
    scrapeConfigSelector: null
Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7157047 View commit details
    Browse the repository at this point in the history

  2. [kube-prometheus-stack] Implement POC basing on @jkroepke's suggestio… 

    …n in prometheus-community#4818

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    739fe4c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. [kube-prometheus-stack] Implement POC basing on @jkroepke's 2nd sugge… 

    …stion in prometheus-community#4818

prometheus-community#4818 (comment)
Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b83ccf1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. [kube-prometheus-stack] Bring back scrapeConfigNamespaceSelector 

    Was removed by accident.

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a392b2e View commit details
    Browse the repository at this point in the history

  2. [kube-prometheus-stack] Accept @jkroepke's suggestion from prometheus… 

    …-community#4818

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7bc0e3d View commit details
    Browse the repository at this point in the history

  3. [kube-prometheus-stack] Clean up comment on scrapeConfigSelector 

    Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    40228b0 View commit details
    Browse the repository at this point in the history

  4. [kube-prometheus-stack] Implement exemplary logic described in promet… 

    …heus-community#4818

For a selector (scrapeConfigSelector)
and a namespaceSelector (scrapeConfigNamespaceSelector)

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6f3d826 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. [kube-prometheus-stack] Implement other selectors as described promet… 

    …heus-community#4818

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5ed8cef View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. [kube-prometheus-stack] Implement deprecation warning for *NilUsesHel… 

    …mValues

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e38007a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. [kube-prometheus-stack] Fix docs for *SelectorNilUsesHelmValues 

    As found in @jkroepke's review.

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    39d577a View commit details
    Browse the repository at this point in the history

  2. [kube-state-metrics] Add missing selectors 

    Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
    @jkroepke
    jkroepke committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3a2962a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'main' into feature/downward-compat-prom-crd 

    Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
    @jkroepke
    jkroepke authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4316c8a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. [kube-prometheus-stack] Fix trailing spaces 

    As found by linter

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    818cf05 View commit details
    Browse the repository at this point in the history

  2. [kube-prometheus-stack] Fix trailing spaces 

    As found by linter

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9481ee0 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. [kube-prometheus-stack] README: Fix markdown formatting 

    As found by next linter

Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
    @schnatterer
    schnatterer committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    60dc2dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/downward-compat-prom-crd

    @schnatterer
    schnatterer authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8749900 View commit details
    Browse the repository at this point in the history