[prometheus-mongodb-exporter] Support multi-target exporter #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BapRx
force-pushed
the
feat/mongodb-multi-target
branch
from
177b1df
to
9428fb9
Compare
BapRx
force-pushed
the
feat/mongodb-multi-target
branch
from
0001b62
to
c0d1b1a
Compare
zeritti
requested changes
Oct 29, 2024
charts/prometheus-mongodb-exporter/templates/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
charts/prometheus-mongodb-exporter/templates/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
BapRx
force-pushed
the
feat/mongodb-multi-target
branch
from
c0d1b1a
to
4f647c9
Compare
Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
|
Hello @zeritti, thank you for your review, I pushed some changes to fix the issues you mentioned. |
Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
|
Thank you, @BapRx, for your changes. I will still validate the changes over the coming days. As to the chosen use case of a single set of credentials, I am confident that we can start with that. |
Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
|
A CI values file for |
Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
I see, thank you 🙂 |
zeritti
approved these changes
Nov 3, 2024
kranthikirang
pushed a commit
to kranthikirang/helm-charts
that referenced
this pull request
Nov 5, 2024
…us-community#4875) * feat(mongodb): support multi-target exporter Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * feat(prometheus-mongodb-exporter): apply suggestions Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * chore(prometheus-mongodb-exporter): bump chart version Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * chore(prometheus-mongodb-exporter): add CI multi-target test Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * fix(prometheus-mongodb-exporter): rename CI multi-target test file Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> --------- Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
kranthikirang
pushed a commit
to kranthikirang/helm-charts
that referenced
this pull request
Nov 5, 2024
…us-community#4875) * feat(mongodb): support multi-target exporter Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * feat(prometheus-mongodb-exporter): apply suggestions Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * chore(prometheus-mongodb-exporter): bump chart version Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * chore(prometheus-mongodb-exporter): add CI multi-target test Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> * fix(prometheus-mongodb-exporter): rename CI multi-target test file Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com> --------- Signed-off-by: Baptiste Roux <baptiste.roux@skale-5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Allow configuring multiple targets for the exporter v0.40.0 and later.
Which issue this PR fixes
Special notes for your reviewer
Until the exporter supports reading passwords from a file, we are limited to choose out of two solutions:
MONGODB_URIautomatically from the target list BUT share the same username/passwordMONGODB_URIbut also manage the serviceMonitor list separatelyI don't really know what's the best solution, open for suggestions! I went for the first solution which matches my use case but if you think the other option is better for most people, we can rethink the logic.
Checklist
[prometheus-couchdb-exporter])