[prometheus] add tpl to ingress #4956
Merged
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianjedroCDT
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
christianjedroCDT
force-pushed
the
prometheus/add-tpl-to-ingress
branch
from
66e6b72
to
549ca35
Compare
zeritti
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Thank you, @christianjedroCDT, for your PR. Will you please add a CI test case for an ingress?
christianjedroCDT
force-pushed
the
prometheus/add-tpl-to-ingress
branch
2 times, most recently
from
4339b95
to
065a090
Compare
Signed-off-by: Chris Jedro <cj@cloudeteer.de>
christianjedroCDT
force-pushed
the
prometheus/add-tpl-to-ingress
branch
from
065a090
to
a77c50f
Compare
Signed-off-by: Chris Jedro <cj@cloudeteer.de>
Signed-off-by: Chris Jedro <cj@cloudeteer.de>
|
@zeritti thanks for you input! I´ve added the CI test case now. Please let me know if there is anything else needed |
zeritti
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
following the same principle as in kube-prometheus-stack i´ve added the possibility to use tpl within the ingress resource
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])