-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] - targetLabels for all exporters #4973
[kube-prometheus-stack] - targetLabels for all exporters #4973
Conversation
Signed-off-by: kranthikirang <kranthi.guttikonda9@gmail.com>
In our cases, we modified the serviceMonitor relabel config directly via values and add a cluster label everywhere. kubelet:
namespace: opsstack
serviceMonitor:
relabelings:
- action: replace
sourceLabels: [__metrics_path__]
targetLabel: metrics_path
- targetLabel: cluster
replacement: opsstack
cAdvisorRelabelings:
- action: replace
sourceLabels: [__metrics_path__]
targetLabel: metrics_path
- targetLabel: cluster
replacement: opsstack
probesRelabelings:
- action: replace
sourceLabels: [__metrics_path__]
targetLabel: metrics_path
- targetLabel: cluster
replacement: opsstack
resourceRelabelings:
- action: replace
sourceLabels: [__metrics_path__]
targetLabel: metrics_path
- targetLabel: cluster
replacement: opsstack |
charts/kube-prometheus-stack/templates/prometheus-operator/deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: kranthikirang <kranthi.guttikonda9@gmail.com>
Signed-off-by: kranthikirang <kranthi.guttikonda9@gmail.com>
Signed-off-by: kranthikirang <kranthi.guttikonda9@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I found one thing and please add a test case for the extra arg here:
prometheusOperator: |
Once done, I fine to merge it.
charts/kube-prometheus-stack/templates/prometheus-operator/deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: kranthikirang <kranthi.guttikonda9@gmail.com>
@jkroepke Can you please check now? |
charts/kube-prometheus-stack/templates/prometheus-operator/deployment.yaml
Outdated
Show resolved
Hide resolved
…loyment.yaml Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What this PR does / why we need it
This PR will add the support for targetLabels for all exporters in kube-prometheus-stack
Which issue this PR fixes