Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added errcheck, test to makefile, added circle CI config. #33

Merged
merged 1 commit into from
May 10, 2019

Conversation

bwplotka
Copy link
Member

And we have first unit test! ;p

Signed-off-by: Bartek Plotka bwplotka@gmail.com

@bwplotka bwplotka requested a review from free May 10, 2019 11:24
And we have first unit test! ;p

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Copy link
Member

@free free left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bwplotka bwplotka merged commit 91f95ea into master May 10, 2019
@bwplotka bwplotka deleted the circleCi branch May 10, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants