Skip to content

Fix bool support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2020
+19 −0
Merged

Fix bool support #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cb836f
jsonexporter/scraper: fix bool support
davdr Jun 13, 2020
c58897c
demo bool support in the example
davdr Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -20,16 +20,19 @@ $ cat example/data.json
{
"id": "id-A",
"count": 1,
"some_boolean": true,
"state": "ACTIVE"
},
{
"id": "id-B",
"count": 2,
"some_boolean": true,
"state": "INACTIVE"
},
{
"id": "id-C",
"count": 3,
"some_boolean": false,
"state": "ACTIVE"
},
]
@@ -50,20 +53,25 @@ $ cat example/config.yml
values:
active: 1 # static value
count: $.count # dynamic value
boolean: $.some_boolean

$ python -m SimpleHTTPServer 8000 &
Serving HTTP on 0.0.0.0 port 8000 ...

$ ./json_exporter http://localhost:8000/example/data.json example/config.yml &
INFO[2016-02-08T22:44:38+09:00] metric registered;name:<example_global_value>
INFO[2016-02-08T22:44:38+09:00] metric registered;name:<example_value_boolean>
INFO[2016-02-08T22:44:38+09:00] metric registered;name:<example_value_active>
INFO[2016-02-08T22:44:38+09:00] metric registered;name:<example_value_count>
127.0.0.1 - - [08/Feb/2016 22:44:38] "GET /example/data.json HTTP/1.1" 200 -


$ curl http://localhost:7979/metrics | grep ^example
example_global_value{environment="beta"} 1234
example_value_active{environment="beta",id="id-A"} 1
example_value_active{environment="beta",id="id-C"} 1
example_value_boolean{environment="beta",id="id-A"} 1
example_value_boolean{environment="beta",id="id-C"} 0
example_value_count{environment="beta",id="id-A"} 1
example_value_count{environment="beta",id="id-C"} 3
```
1 change: 1 addition & 0 deletions example/config.yml
View file
Original file line number Diff line number Diff line change
@@ -12,3 +12,4 @@
values:
active: 1 # static value
count: $.count # dynamic value
boolean: $.some_boolean
3 changes: 3 additions & 0 deletions example/data.json
View file
Original file line number Diff line number Diff line change
@@ -4,16 +4,19 @@
{
"id": "id-A",
"count": 1,
"some_boolean": true,
"state": "ACTIVE"
},
{
"id": "id-B",
"count": 2,
"some_boolean": true,
"state": "INACTIVE"
},
{
"id": "id-C",
"count": 3,
"some_boolean": false,
"state": "ACTIVE"
},
]
7 changes: 7 additions & 0 deletions jsonexporter/scraper.go
View file
Original file line number Diff line number Diff line change
@@ -209,6 +209,7 @@ func (obsc *ObjectScraper) Scrape(data []byte, reg *harness.MetricRegistry) erro
}

var value float64
var boolValue bool
switch firstResult.Type {
case jsonpath.JsonNumber:
value, err = obsc.parseValue(firstResult.Value)
@@ -217,6 +218,12 @@ func (obsc *ObjectScraper) Scrape(data []byte, reg *harness.MetricRegistry) erro
value, err = obsc.parseValue(firstResult.Value[1 : len(firstResult.Value)-1])
case jsonpath.JsonNull:
value = math.NaN()
case jsonpath.JsonBool:
if boolValue, err = strconv.ParseBool(string(firstResult.Value)); boolValue {
value = 1.0
} else {
value = 0.0
}
default:
log.Warnf("skipping not numerical result;path:<%v>,value:<%s>",
obsc.valueJsonPath, result.Value)