Do not add roleMetrics when row is not valid

prometheus-community · Jan 24, 2024 · 0687481 · 0687481
1 parent 3c1fb00
commit 0687481
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/collector/pg_roles.go b/collector/pg_roles.go
@@ -71,15 +71,15 @@ func (c PGRolesCollector) Update(ctx context.Context, instance *instance, ch cha
 			return err
 		}
 
-		rolnameLabel := "unknown"
-		if rolname.Valid {
-			rolnameLabel = rolname.String
+		if !rolname.Valid {
+			continue
 		}
+		rolnameLabel := rolname.String
 
-		connLimitMetric := 0.0
-		if connLimit.Valid {
-			connLimitMetric = float64(connLimit.Int64)
+		if !connLimit.Valid {
+			continue
 		}
+		connLimitMetric := float64(connLimit.Int64)
 
 		ch <- prometheus.MustNewConstMetric(
 			pgRolesConnectionLimitsDesc,

diff --git a/collector/pg_roles_test.go b/collector/pg_roles_test.go
@@ -79,9 +79,7 @@ func TestPGRolesCollectorNullMetric(t *testing.T) {
 		}
 	}()
 
-	expected := []MetricResult{
-		{labels: labelMap{"rolname": "unknown"}, value: 0, metricType: dto.MetricType_GAUGE},
-	}
+	expected := []MetricResult{}
 	convey.Convey("Metrics comparison", t, func() {
 		for _, expect := range expected {
 			m := readMetric(<-ch)