-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aurora 13.5 returns shared_buffers setting with unit causing a panic #619
Comments
Did you report this to Amazon Aurora? |
Yes, I have sent feedback. Not sure if that was the correct place to do it. |
My postgres-exporter is also crashing with errors: Edit: I build this feature and published on my docker hub. It works perfectly! |
Adds --strip-settings-suffix flag to make the fixes for AWS Aurora in prometheus-community#619 opt in for users. It should be safe for all users, but this code should also be unnecessary if AWS fixes their bug. Signed-off-by: Joe Adams <github@joeadams.io>
@sysadmind - any release tracker that we can follow? We recently upgraded Aurora and this affects us too. |
I have upgraded my AWS Aurora server to 13.5 today and I noticed that
postgres-exporter
started crashing.From the logs, I see that the error is:
I looked at the code and I found a query selecting from
pg_settings
, so I tried it on the server, and indeed,shared_buffers
is returning a value with the unit combined.I tested the same query on a postgres in docker on my machine and 13.5 does not return this value with the unit, so this is something related to Aurora specifically.
I can work on a pull request. But I'm not sure what would be the best method. My thought was to have a test to see if the unit is included in the setting's value and strip it if it is the case.
This is the
shared_buffer
line from the query:The text was updated successfully, but these errors were encountered: