Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it work with postgres 14? #651

Closed
PhilipMay opened this issue Jun 11, 2022 · 6 comments
Closed

Does it work with postgres 14? #651

PhilipMay opened this issue Jun 11, 2022 · 6 comments

Comments

@PhilipMay
Copy link

The README.md sais:

CI Tested PostgreSQL versions: 9.4, 9.5, 9.6, 10, 11, 12, 13

So what I as a user now thinks: "Does it work with version 14 of postgres?"

Can you maybe add something about this?

@PhilipMay
Copy link
Author

Hi @sysadmind or @paulfantom - maybe one of you can help me here?

@TipTopBY
Copy link

I did not earn from the "box".
The error is the following:
An error has occurred while serving metrics:

11 error(s) occurred:

  • collected metric pg_settings_check_function_bodies label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:1 > has help "Check routine bodies during CREATE FUNCTION and CREATE PROCEDURE." but should have "Check function bodies during CREATE FUNCTION."
  • collected metric pg_settings_data_directory_mode label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:700 > has help "Shows the mode of the data directory." but should have "Mode of the data directory."
  • collected metric pg_settings_enable_partition_pruning label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:1 > has help "Enables plan-time and execution-time partition pruning." but should have "Enables plan-time and run-time partition pruning."
  • collected metric pg_settings_idle_in_transaction_session_timeout_seconds label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:0 > has help "Sets the maximum allowed idle time between queries, when in a transaction. [Units converted to seconds.]" but should have "Sets the maximum allowed duration of any idling transaction. [Units converted to seconds.]"
  • collected metric pg_settings_integer_datetimes label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:1 > has help "Shows whether datetimes are integer based." but should have "Datetimes are integer based."
  • collected metric pg_settings_jit_debugging_support label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:0 > has help "Register JIT-compiled functions with debugger." but should have "Register JIT compiled function with debugger."
  • collected metric pg_settings_jit_optimize_above_cost label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:500000 > has help "Optimize JIT-compiled functions if query is more expensive." but should have "Optimize JITed functions if query is more expensive."
  • collected metric pg_settings_jit_profiling_support label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:0 > has help "Register JIT-compiled functions with perf profiler." but should have "Register JIT compiled function with perf profiler."
  • collected metric pg_settings_log_min_duration_statement_seconds label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:-1 > has help "Sets the minimum execution time above which all statements will be logged. [Units converted to seconds.]" but should have "Sets the minimum execution time above which statements will be logged. [Units converted to seconds.]"
  • collected metric pg_settings_log_transaction_sample_rate label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:0 > has help "Sets the fraction of transactions from which to log all statements." but should have "Set the fraction of transactions to log for new transactions."
  • collected metric pg_settings_parallel_tuple_cost label:<name:"server" value:"dev-postgres.test:5432" > gauge:<value:0.1 > has help "Sets the planner's estimate of the cost of passing each tuple (row) from worker to leader backend." but should have "Sets the planner's estimate of the cost of passing each tuple (row) from worker to master backend."

@PhilipMay
Copy link
Author

@TipTopBY what does that mean? Is that an answer to my question?
Did you post to the wrong issue?

@godber
Copy link
Contributor

godber commented Jun 15, 2022

The CI appears to include PostgreSQL 14.1 in the text matrix here:

https://github.com/prometheus-community/postgres_exporter/blame/master/.circleci/config.yml#L63

And tests appear to run against that version as shown here:

https://app.circleci.com/pipelines/github/prometheus-community/postgres_exporter/274/workflows/8194a4bb-e942-4318-b9ba-3f066ab98429/jobs/2234

I'd say the documents just need updating.

godber added a commit to godber/postgres_exporter that referenced this issue Jun 15, 2022
godber added a commit to godber/postgres_exporter that referenced this issue Jun 15, 2022
It looks like postgres 14.1 was added to CI here:

prometheus-community@fcb2535

See also: prometheus-community#651 (comment)

Signed-off-by: Austin Godber <godber@uberhip.com>
@sysadmind
Copy link
Contributor

PR merged for docs fix. The CI does include Postgres 14.1. If you run into any issues with 14, please feel free to open a new issue. Thanks @godber

@PhilipMay
Copy link
Author

Thanks. :-)

ademidoff pushed a commit to percona/postgres_exporter that referenced this issue Oct 12, 2022
* Update build

* Update to Go 1.18.
* Update minimum Go version to 1.17.
* Update Go modules for 1.17 format.
* Bump Go modules
* Enable dependabot.
* Update Prometheus common files.
* Fixup yamllint.

Signed-off-by: SuperQ <superq@gmail.com>

* Update common Prometheus files

Signed-off-by: prombot <prometheus-team@googlegroups.com>

* Update common Prometheus files (prometheus-community#650)

Signed-off-by: prombot <prometheus-team@googlegroups.com>

* Update common Prometheus files

Signed-off-by: prombot <prometheus-team@googlegroups.com>

* Update readme to include Postgres 14 support

It looks like postgres 14.1 was added to CI here:

prometheus-community@fcb2535

See also: prometheus-community#651 (comment)

Signed-off-by: Austin Godber <godber@uberhip.com>

* Bump github.com/prometheus/common from 0.34.0 to 0.35.0

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.34.0 to 0.35.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.34.0...v0.35.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Release v0.11.0

NOTE: pg_stat_bgwriter counter metrics had the `_total` suffix added prometheus-community#556

* [CHANGE] refactor pg_stat_bgwriter metrics into standalone collector prometheus-community#556
* [FEATURE] Add pg_database collector prometheus-community#613
* [ENHANCEMENT] Add pg_database_size_bytes metric prometheus-community#613
* [BUGFIX] Avoid parsing error from bogus Azure Flexible Server custom GUC prometheus-community#587
* [BUGFIX] Fix pg_stat_archiver error in 9.4 and earlier. prometheus-community#599
* [BUGFIX] Sanitize setting values because of Aurora irregularity prometheus-community#620

Signed-off-by: SuperQ <superq@gmail.com>

* fix for exporter issue 633

fix for exporter issue 633: prometheus-community#633

"Scan error on column index 2, name \"checkpoint_write_time\": converting driver.Value type float64 (\"6.594096e+06\") to a int: invalid syntax prometheus-community#633"

Signed-off-by: bravosierrasierra <bravosierrasierra@users.noreply.github.com>

* Fix checkpoint_sync_time value type

Error:
sql: Scan error on column index 3, name \"checkpoint_sync_time\": converting driver.Value type float64 (\"1.876469e+06\") to a int: invalid syntax

See also:
prometheus-community#633
prometheus-community#666

Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>

* Release 0.11.1

* [BUGFIX] Fix checkpoint_write_time value type prometheus-community#666
* [BUGFIX] Fix checkpoint_sync_time value type prometheus-community#667

Signed-off-by: SuperQ <superq@gmail.com>

* PMM-10820 missing metric restore

* PMM-10820 missing metric drop

* PMM-10820 merge fix

* PMM-10820 PR review fix

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Austin Godber <godber@uberhip.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: bravosierrasierra <bravosierrasierra@users.noreply.github.com>
Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>
Co-authored-by: SuperQ <superq@gmail.com>
Co-authored-by: prombot <prometheus-team@googlegroups.com>
Co-authored-by: Austin Godber <godber@uberhip.com>
Co-authored-by: Joe Adams <github@joeadams.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bravosierrasierra <bravosierrasierra@users.noreply.github.com>
Co-authored-by: Nicolas Rodriguez <nico@nicoladmin.fr>
ritbl pushed a commit to heniek/postgres_exporter that referenced this issue Mar 19, 2023
It looks like postgres 14.1 was added to CI here:

prometheus-community@fcb2535

See also: prometheus-community#651 (comment)

Signed-off-by: Austin Godber <godber@uberhip.com>
ritbl pushed a commit to heniek/postgres_exporter that referenced this issue Mar 19, 2023
* Update build

* Update to Go 1.18.
* Update minimum Go version to 1.17.
* Update Go modules for 1.17 format.
* Bump Go modules
* Enable dependabot.
* Update Prometheus common files.
* Fixup yamllint.

Signed-off-by: SuperQ <superq@gmail.com>

* Update common Prometheus files

Signed-off-by: prombot <prometheus-team@googlegroups.com>

* Update common Prometheus files (prometheus-community#650)

Signed-off-by: prombot <prometheus-team@googlegroups.com>

* Update common Prometheus files

Signed-off-by: prombot <prometheus-team@googlegroups.com>

* Update readme to include Postgres 14 support

It looks like postgres 14.1 was added to CI here:

prometheus-community@fcb2535

See also: prometheus-community#651 (comment)

Signed-off-by: Austin Godber <godber@uberhip.com>

* Bump github.com/prometheus/common from 0.34.0 to 0.35.0

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.34.0 to 0.35.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.34.0...v0.35.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Release v0.11.0

NOTE: pg_stat_bgwriter counter metrics had the `_total` suffix added prometheus-community#556

* [CHANGE] refactor pg_stat_bgwriter metrics into standalone collector prometheus-community#556
* [FEATURE] Add pg_database collector prometheus-community#613
* [ENHANCEMENT] Add pg_database_size_bytes metric prometheus-community#613
* [BUGFIX] Avoid parsing error from bogus Azure Flexible Server custom GUC prometheus-community#587
* [BUGFIX] Fix pg_stat_archiver error in 9.4 and earlier. prometheus-community#599
* [BUGFIX] Sanitize setting values because of Aurora irregularity prometheus-community#620

Signed-off-by: SuperQ <superq@gmail.com>

* fix for exporter issue 633

fix for exporter issue 633: prometheus-community#633

"Scan error on column index 2, name \"checkpoint_write_time\": converting driver.Value type float64 (\"6.594096e+06\") to a int: invalid syntax prometheus-community#633"

Signed-off-by: bravosierrasierra <bravosierrasierra@users.noreply.github.com>

* Fix checkpoint_sync_time value type

Error:
sql: Scan error on column index 3, name \"checkpoint_sync_time\": converting driver.Value type float64 (\"1.876469e+06\") to a int: invalid syntax

See also:
prometheus-community#633
prometheus-community#666

Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>

* Release 0.11.1

* [BUGFIX] Fix checkpoint_write_time value type prometheus-community#666
* [BUGFIX] Fix checkpoint_sync_time value type prometheus-community#667

Signed-off-by: SuperQ <superq@gmail.com>

* PMM-10820 missing metric restore

* PMM-10820 missing metric drop

* PMM-10820 merge fix

* PMM-10820 PR review fix

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Austin Godber <godber@uberhip.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: bravosierrasierra <bravosierrasierra@users.noreply.github.com>
Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>
Co-authored-by: SuperQ <superq@gmail.com>
Co-authored-by: prombot <prometheus-team@googlegroups.com>
Co-authored-by: Austin Godber <godber@uberhip.com>
Co-authored-by: Joe Adams <github@joeadams.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bravosierrasierra <bravosierrasierra@users.noreply.github.com>
Co-authored-by: Nicolas Rodriguez <nico@nicoladmin.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants