Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to scrape dynamic targets #468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ability to scrape dynamic targets #468

wants to merge 1 commit into from

Conversation

wimoMisterX
Copy link

@wimoMisterX wimoMisterX commented Jan 6, 2021 •
edited by SuperQ
Loading

@SuperQ
Copy link
Contributor

SuperQ commented Mar 1, 2021

Thanks, this is a good start towards adding multi-target support.

Would you please rebase this so that the tests can run?

@SuperQ SuperQ mentioned this pull request Mar 1, 2021
Open
@wimoMisterX wimoMisterX force-pushed the dynamic-scrape-targets branch 3 times, most recently from daf3bb8 to f37acc8 Compare March 1, 2021 09:51
@wimoMisterX
Copy link
Author

@SuperQ the tests are passing, is there anything else I need to do before we can merge this?

@SuperQ
Copy link
Contributor

SuperQ commented Mar 1, 2021

Thanks, give me a bit to review a couple things. To start, add some documentation to the README about how to use it.

@wimoMisterX wimoMisterX force-pushed the dynamic-scrape-targets branch from f37acc8 to 5ac5e44 Compare March 1, 2021 10:25
@SuperQ
Copy link
Contributor

SuperQ commented Mar 1, 2021

Take a look at the probeHandler() function in the json_exporter. It minimizes the amount of inline code in http.HandleFunc().

@SuperQ
Copy link
Contributor

SuperQ commented Mar 1, 2021

In addition, the probeHandler() pattern allows for easy testing. Take a look at the cmd/main_test.go in the json_exporter.

@SuperQ
Copy link
Contributor

SuperQ commented Mar 9, 2021

Have you had a chance to look at how this is implemented in the json_exporter? I would like it done that way, and tests added.

@wimoMisterX wimoMisterX force-pushed the dynamic-scrape-targets branch from 5ac5e44 to 931fd96 Compare July 21, 2021 15:59
Ability to scrape dynamic targets
afbd8b8 
Signed-off-by: Wimo <wimo@wimodya-athukorala.com>
@wimoMisterX wimoMisterX force-pushed the dynamic-scrape-targets branch from 931fd96 to afbd8b8 Compare July 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wimoMisterX @SuperQ