Skip to content

Fix replication_slot query all supported versions #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

halvaborsch
Copy link
Contributor

The right way to fix #495
Lets not forget about older postgres version.

@hd-deman
Copy link

hd-deman commented Jun 1, 2021

@halvaborsch can you please fix DCO. Really looking forward to this MR

Signed-off-by: Филатов Дмитрий <d.filatov@2gis.ru>
@halvaborsch halvaborsch force-pushed the halvaborsch-replication-slot-patch-1 branch from f3eef51 to 29f6fa1 Compare June 1, 2021 12:00
@halvaborsch
Copy link
Contributor Author

@hd-deman sure sry

@hd-deman
Copy link

hd-deman commented Jun 1, 2021

@SuperQ can you review pls 🙏

@AitorAcosta
Copy link

Any news on this?
Thx

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@SuperQ SuperQ merged commit 134e908 into prometheus-community:master Jun 10, 2021
@neuromantik33
Copy link

Great! When can we expect a new tag?

@Siuddek
Copy link

Siuddek commented Jun 23, 2021

Nice! Is there any release date for this fix?

ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
…sch-replication-slot-patch-1

Fix replication_slot query all supported versions
@WalkerWalker
Copy link

WalkerWalker commented Mar 27, 2023

is there already a release including this tag?

I found it. Thanks

https://github.com/prometheus-community/postgres_exporter/releases/tag/v0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function pg_current_wal_lsn() not exists on 9.5.x
7 participants