forked from soundcloud/rsyslog_exporter
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add omkafka support #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse omkafka statistics according to https://www.rsyslog.com/doc/configuration/modules/omkafka.html#statistic-counter Signed-off-by: Janis Meybohm <jmeybohm@wikimedia.org>
jayme-github
force-pushed
the
omkafka
branch
from
February 20, 2024 14:34
d64f2d0
to
9a761f8
Compare
LGTM! Thank you @jayme-github ! Sample metrics for reference:
|
aleroyer
approved these changes
Feb 22, 2024
Thank your for your contribution. |
jayme-github
added a commit
to wikimedia/rsyslog_exporter
that referenced
this pull request
Feb 22, 2024
This is a follow up fixing an error I made in prometheus-community#12
jayme-github
added a commit
to wikimedia/rsyslog_exporter
that referenced
this pull request
Feb 22, 2024
This is a follow up fixing an error I made in prometheus-community#12 Signed-off-by: Janis Meybohm <jmeybohm@wikimedia.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse omkafka statistics according to
https://www.rsyslog.com/doc/configuration/modules/omkafka.html#statistic-counter
cc @filippog