Do not treat failure to collect metrics as fatal #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
Thanks. @cpick, do you have a specific error that we could handle for credentials not being valid anymore? |
|
We are seeing constant restarts due to timeouts against stackdriver. Would be nice if we can get the previous behaviour back. |
|
Yes, I agree, let's merge this and work on what to do about the credential case separately. |
|
Following up on handling the authentication issues more specifically in #101. |
|
A release with this fix would be great :) |
|
@SuperQ ^^ |
Merged
SuperQ
added a commit
that referenced
this pull request
Sep 2, 2020
* Release 0.11.0 * Bump Go to 1.15. * [CHANGE] Do not treat failure to collect metrics as fatal #102 * [FEATURE] Add support for multiple google project IDs #105 Signed-off-by: Ben Kochie <superq@gmail.com> * Update vendoring Signed-off-by: Ben Kochie <superq@gmail.com> * Bump promu version. Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #83 (see discussion in the issue for more information).