Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add monitoring.filters flag #133

Merged
merged 16 commits into from
Feb 6, 2022
Merged

add monitoring.filters flag #133

merged 16 commits into from
Feb 6, 2022

Conversation

vrunoa
Copy link
Contributor

@vrunoa vrunoa commented Nov 3, 2021 •
edited
Loading

What does this change do?

Add monitoring.filters flag

Why is it needed?

Allow more granularity when requesting for time series list by letting developers refine their metrics by using Filter objects that Google provides.

Filter objects: project, group.id, resource.type, resource.labels.[KEY], metric.type, metric.labels.[KEY]

https://cloud.google.com/monitoring/api/v3/filters

Example

go run stackdriver_exporter.go \
  --google.project-id=my-project \
  --monitoring.metrics-type-prefixes='pubsub.googleapis.com/subscription/num_undelivered_messages,redis.googleapis.com' \
  --monitoring.filters='pubsub.googleapis.com/subscription:resource.labels.subscription_id=monitoring.regex.full_match("us-west4.*my-team.*")'

@vrunoa vrunoa force-pushed the add-extra-filter-option branch 2 times, most recently from 932fa78 to b00863c Compare November 3, 2021 05:27
@vrunoa vrunoa changed the title add monitoring.extra.filter flag add monitoring.extra.filters flag Nov 8, 2021
@vrunoa vrunoa closed this Nov 8, 2021
@vrunoa vrunoa reopened this Nov 12, 2021
@vrunoa vrunoa force-pushed the add-extra-filter-option branch 2 times, most recently from f5cebdb to b51d994 Compare November 12, 2021 00:31
SuperQ
SuperQ requested changes Jan 31, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@vrunoa
add monitoring.extra.filter flag
d656a75 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
fix lint
7f688af 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
use string to give more flexibility on filter to allow devs use AND/OR
970a7c2 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
using filter by prefix
476664d 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
add method to get extra filter flags prefix and modifiers
6b3ce15 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
pre create filters
52893c7 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
remove extra if statement
267f07d 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
update example
7c75be0 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
update README
5796dc6 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
rename flag
d9dfbe3 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
rename var
31e98cf 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
fix lint
528112e 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
update flag to .filters
ee27163 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
update readme
2b7a87b 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
update readme
5f0bfac 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
@vrunoa
update readme
5220429 
Signed-off-by: vrunoa <vruno.alassia@gmail.com>
SuperQ
SuperQ approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vrunoa vrunoa changed the title add monitoring.extra.filters flag add monitoring.filters flag Feb 4, 2022
@SuperQ SuperQ merged commit 882f61d into prometheus-community:master Feb 6, 2022
SuperQ added a commit that referenced this pull request Feb 7, 2022
@SuperQ
Release 0.12.0
0a076d5 
Breaking Changes:

The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments.

* [CHANGE] Cleanup non-standard ENV var setup #142
* [FEATURE] Add support to include ingest delay when pull metrics #129
* [FEATURE] Add monitoring.filters flag #133
* [ENHANCEMENT] Setup exporter metrics only once when we can #124

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Feb 7, 2022
Merged
SuperQ added a commit that referenced this pull request Feb 9, 2022
@SuperQ
Release 0.12.0 (#143)
cd3d54a 
Breaking Changes:

The exporter nolonger supports configuration via ENV vars. This was a non-standard feature that is not part of the Prometheus ecossystem. All configuration is now handled by the existing command line arguments.

* [CHANGE] Cleanup non-standard ENV var setup #142
* [FEATURE] Add support to include ingest delay when pull metrics #129
* [FEATURE] Add monitoring.filters flag #133
* [ENHANCEMENT] Setup exporter metrics only once when we can #124

Signed-off-by: SuperQ <superq@gmail.com>
@dfredell dfredell mentioned this pull request Feb 11, 2022
Merged
@namm2 namm2 mentioned this pull request Jul 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrunoa @SuperQ