-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to support runtime metrics on a seperate path #173
Make it possible to support runtime metrics on a seperate path #173
Conversation
Signed-off-by: Hassan Syed <hassan.syed@paymentsense.com>
0b2c549
to
d6dd618
Compare
Signed-off-by: Hassan Syed <hassan.syed@paymentsense.com>
ebaaeec
to
80c41e2
Compare
Interesting idea. What specifically about your deployments will reduce the number of calls? |
@SuperQ we intend to orchestrate our scrapers to have a seperate scrape job for the runtime metrics -- possibly with a tighter interval. As we have to orchestrate with multiple deployments due to quantity of metrics we need to ingest (divide and conquer) , this approach has the additional benefit of allowing us to model multiple stackdriver_exporter deployments ergonomically in our helm meta-chart. |
I wonder if we should have this flag do the opposite. Have I'm suggesting this because we're likely to move the |
@SuperQ yes changing the polarity of the flag would be the same for us. I'll update the PR. We explored using query params to provide the filters and this might allow us to have a single deployment. The stackdriver API call metrics are specific to the registry created for the exposition and they reset on each call with the approach (IIRC). I think we would want those metrics to probably be cumulative/global (or with a use-case label --e.g., |
Signed-off-by: Hassan Syed <hassan.syed@paymentsense.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks.
@SuperQ
This PR introduces a new flag to make it possible to serve the go runtime metrics on a seperate endpoint. The way we are orchestrating the deployment of the exporter (multiple k8s deployments), this flag will effectively halve our stackdriver API calls.
Manual testing done: