Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace comma-delimited string flags with repeatable flags #355

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

tommyzli
Copy link
Contributor

@tommyzli tommyzli commented Aug 1, 2024

Closes #44
The original issue is pretty old but the feature request still holds up, I too find it more ergonomic to manage repeatable flags rather than a large comma-delimited string. As suggested in the issue, I also changed metrics-type-prefixes to just metrics-prefixes

@tommyzli tommyzli force-pushed the repeat-flag branch 2 times, most recently from 904c473 to 46c70ae Compare August 1, 2024 18:18
@SuperQ SuperQ requested a review from kgeckhart August 30, 2024 13:12
@SuperQ
Copy link
Contributor

SuperQ commented Aug 30, 2024

I like it, mind doing a rebase?

Signed-off-by: Tommy Li <tommy.li@clickhouse.com>
@tommyzli
Copy link
Contributor Author

@SuperQ Done, thanks

@SuperQ
Copy link
Contributor

SuperQ commented Aug 31, 2024

I wonder if it would be worth keeping the original flag as-is, and append the strings.Split() to the new flag results. Then mark the original flag as deprecated and print a warning in the log.

stackdriver_exporter.go Show resolved Hide resolved
@tommyzli tommyzli requested a review from SuperQ September 4, 2024 17:50
Signed-off-by: Tommy Li <tommy.li@clickhouse.com>
Copy link
Contributor

@kgeckhart kgeckhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kgeckhart kgeckhart merged commit 157cf40 into prometheus-community:master Oct 7, 2024
3 checks passed
@kgeckhart kgeckhart mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Allow metrics-type-prefixes using multiple flags
3 participants