Skip missing IIS instances #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this please? when this will be merged and released? |
Collector would previously break from loop rather than skip nameless entries, with the additional result of spamming event logs. Signed-off-by: Ben Reedy <breed808@breed808.com>
|
@carlpett I'm going to merge this now. Ping me if this needs to be revisited. |
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
Skip missing IIS instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collector would previously break from loop rather than skip nameless
entries, with the additional result of spamming event logs.
I wasn't able to re-open the PR in #985 due to the original branch being destroyed, so consider this a continuation of the discussion.
Resolves #975