Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Avg logical disk RW Queue metrics #1113

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Add Avg logical disk RW Queue metrics #1113

merged 4 commits into from
Jan 3, 2023

Conversation

tehseenshahab
Copy link
Contributor

Add LogicalDisk metrics

  1. AvgDiskReadQueueLength
  2. AvgDiskWriteQueueLength

@tehseenshahab tehseenshahab requested a review from a team as a code owner December 30, 2022 02:18
@tehseenshahab tehseenshahab force-pushed the tesh-logical-disk-collector-extension branch 2 times, most recently from 728b54f to bbf7d1b Compare December 30, 2022 11:06
@tehseenshahab tehseenshahab force-pushed the tesh-logical-disk-collector-extension branch from 5132528 to d13c26c Compare January 1, 2023 17:19
breed808
breed808 reviewed Jan 1, 2023
View reviewed changes
collector/logical_disk.go Outdated Show resolved Hide resolved
breed808
breed808 reviewed Jan 2, 2023
View reviewed changes
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! There's a couple items required to pass the CI checks, then we can merge:

  • Add the new metrics to the tools/e2e-output.txt file
  • Sign the commits for the DCO check

@tehseenshahab tehseenshahab force-pushed the tesh-logical-disk-collector-extension branch 3 times, most recently from 379fb42 to 19f0a8c Compare January 2, 2023 10:00
Tehseen Shahab and others added 4 commits January 2, 2023 11:02
@tehseenshahab
Add Avg logical disk RW Queue metrics
66a1e18 
Signed-off-by: Tehseen Shahab <tehseen.shahab@gmail.com>
@tehseenshahab
Update metric type to gauge
7479946 
Signed-off-by: Tehseen Shahab <tehseen.shahab@gmail.com>
@tehseenshahab
Update metric type to gauge
f10a06f 
Signed-off-by: Tehseen Shahab <tehseen.shahab@gmail.com>
@tehseenshahab
Update e2e output for new metrics
d0c6d13 
Signed-off-by: Tehseen Shahab <tehseen.shahab@gmail.com>
@tehseenshahab tehseenshahab force-pushed the tesh-logical-disk-collector-extension branch from 19f0a8c to d0c6d13 Compare January 2, 2023 10:03
@tehseenshahab
Copy link
Contributor Author

Looking good! There's a couple items required to pass the CI checks, then we can merge:

  • Add the new metrics to the tools/e2e-output.txt file
  • Sign the commits for the DCO check

I have signed all the commits. Not sure where is the issue now for DCO check

@breed808
Copy link
Contributor

breed808 commented Jan 3, 2023 •
edited
Loading

Author field in 66a1e18 appears to the issue:

commit 66a1e18c32d6fac0f8204fba87fd36f160c2fa48
Author: Tehseen Shahab <“redacted@gmail.com”>
Commit: Tehseen Shahab <redacted@gmail.com>

    Add Avg logical disk RW Queue metrics
    
    Signed-off-by: Tehseen Shahab <redacted@gmail.com>

I'd say the quotes in the email address are the cause.

It's not a blocker; if the other CI checks pass I'll get it merged.

breed808
breed808 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breed808 breed808 merged commit 260e343 into prometheus-community:master Jan 3, 2023
@tehseenshahab
Copy link
Contributor Author

👍

Thanks @breed808 Ben,
When can we expect a new release with the new features? Thanks

@breed808
Copy link
Contributor

breed808 commented Jan 3, 2023

I'll make a release candidate for v0.21.0 available in the next day or two.

anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
@breed808
Merge pull request prometheus-community#1113 from tehseenshahab/tesh-…
e888b2d 
…logical-disk-collector-extension

Add Avg logical disk RW Queue metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breed808 breed808 breed808 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tehseenshahab @breed808