-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label user to process collector #1472
Add label user to process collector #1472
Conversation
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
…ows_exporter into feature/collector/process
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR on my local system and it works.
However, I see that the collector is 10 times slower compared to master branch.
master:
windows_exporter_collector_duration_seconds{collector="process"} 0.0121184
PR:
windows_exporter_collector_duration_seconds{collector="process"} 0.1610989
Thats to much. I have provide some suggestions, I hope they help. After apply the suggestion, verify locally, if everything still works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR on my local system and it works.
However, I see that the collector is 10 times slower compared to master branch.
master:
windows_exporter_collector_duration_seconds{collector="process"} 0.0121184
PR:
windows_exporter_collector_duration_seconds{collector="process"} 0.1610989
Thats to much. I have provide some suggestions, I hope they help. After apply the suggestion, verify locally, if everything still works as expected.
…rter into feature/collector/process
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
@jkroepke After the changes, it still works, but I'm not sure it improved the speed |
Hey @aburtasov I looked into it and in term of performance, it overhead compared to the first version is low now. However, I would also looked into it, if I can avoid the WMI query. Thats something, what I will looked into it. |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Please take a look, if it still works for you. |
@jkroepke Hi! I tried the new version with your latest commit. There is no "user" label. Do I understand correctly, you want to optimize the process of adding the "user" label? |
Hey @aburtasov the feature is now optional, behind a toggle |
@jkroepke Good job. Everything works correctly. |
…rter to v0.27.1 (#34332) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus-community/windows_exporter](https://togithub.com/prometheus-community/windows_exporter) | `v0.25.1` -> `v0.27.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus-community%2fwindows_exporter/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus-community%2fwindows_exporter/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus-community%2fwindows_exporter/v0.25.1/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus-community%2fwindows_exporter/v0.25.1/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus-community/windows_exporter (github.com/prometheus-community/windows_exporter)</summary> ### [`v0.27.1`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.27.1) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.27.0...v0.27.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 🐞 Bug Fixes - mssql: fix nil panic, if YAML file is used a configuration by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1570](https://togithub.com/prometheus-community/windows_exporter/pull/1570) ##### 🛠️ Dependencies - chore(deps): bump golang.org/x/sys from 0.23.0 to 0.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1566](https://togithub.com/prometheus-community/windows_exporter/pull/1566) **Full Changelog**: prometheus-community/windows_exporter@v0.27.0...v0.27.1 ### [`v0.27.0`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.27.0) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.26.2...v0.27.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 💥 Breaking Changes - textfile: disable collector by default by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1560](https://togithub.com/prometheus-community/windows_exporter/pull/1560) - chore: Refactor Config Collector API by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1558](https://togithub.com/prometheus-community/windows_exporter/pull/1558) - cleanup collector APIs 1 by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1547](https://togithub.com/prometheus-community/windows_exporter/pull/1547) ##### ✨ Exciting New Features - chore: deprecate teradici_pcoip and vmware_blast collector by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1559](https://togithub.com/prometheus-community/windows_exporter/pull/1559) ##### 🐞 Bug Fixes - installer: do not enable V1 counters by default by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1555](https://togithub.com/prometheus-community/windows_exporter/pull/1555) - scheduled_task: do not report windows_scheduled_task_last_result for task that never run before by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1562](https://togithub.com/prometheus-community/windows_exporter/pull/1562) ##### 🛠️ Dependencies - chore(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1550](https://togithub.com/prometheus-community/windows_exporter/pull/1550) - chore(deps): bump golang.org/x/sys from 0.22.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1549](https://togithub.com/prometheus-community/windows_exporter/pull/1549) **Full Changelog**: prometheus-community/windows_exporter@v0.26.2...v0.27.0 ### [`v0.26.2`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.26.2) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.26.1...v0.26.2) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 🐞 Bug Fixes - printer: expose config struct properties by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1545](https://togithub.com/prometheus-community/windows_exporter/pull/1545) - terminal_services: Fix "The operation completed successfully." error by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1548](https://togithub.com/prometheus-community/windows_exporter/pull/1548) **Full Changelog**: prometheus-community/windows_exporter@v0.26.1...v0.26.2 ### [`v0.26.1`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.26.1) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.26.0...v0.26.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 🐞 Bug Fixes - fix: CPU Collector % Cx Time mismatch by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1542](https://togithub.com/prometheus-community/windows_exporter/pull/1542) - logical_disk: Fix failed to get disk ID for dynamic volumes by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1544](https://togithub.com/prometheus-community/windows_exporter/pull/1544) ##### 🛠️ Dependencies - chore(deps): bump actions/stale from 8 to 9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1541](https://togithub.com/prometheus-community/windows_exporter/pull/1541) **Full Changelog**: prometheus-community/windows_exporter@v0.26.0...v0.26.1 ### [`v0.26.0`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.26.0) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.25.1...v0.26.0) #### What's Changed - fix([#​1390](https://togithub.com/prometheus-community/windows_exporter/issues/1390)): global kingpin instead of app var by [@​DiniFarb](https://togithub.com/DiniFarb) in [https://github.com/prometheus-community/windows_exporter/pull/1397](https://togithub.com/prometheus-community/windows_exporter/pull/1397) - docs!: Remove support for EOL Windows versions by [@​breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1396](https://togithub.com/prometheus-community/windows_exporter/pull/1396) - Fix collector.process.iis flag by [@​jaco-van-zyl-derivco](https://togithub.com/jaco-van-zyl-derivco) in [https://github.com/prometheus-community/windows_exporter/pull/1416](https://togithub.com/prometheus-community/windows_exporter/pull/1416) - fix: Apply query filter to metrics by [@​breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1392](https://togithub.com/prometheus-community/windows_exporter/pull/1392) - Restore Windows 2012 support. by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1446](https://togithub.com/prometheus-community/windows_exporter/pull/1446) - installer: Disable Windows Firewall Exception by default. Can be re-enabled with ADD_FIREWALL_EXCEPTION=yes by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1447](https://togithub.com/prometheus-community/windows_exporter/pull/1447) - Improvement: Add owner_node on resource and resourcegroup for mscluster by [@​webalexeu](https://togithub.com/webalexeu) in [https://github.com/prometheus-community/windows_exporter/pull/1395](https://togithub.com/prometheus-community/windows_exporter/pull/1395) - Add label volume_name to logical_disk collector by [@​aburtasov](https://togithub.com/aburtasov) in [https://github.com/prometheus-community/windows_exporter/pull/1442](https://togithub.com/prometheus-community/windows_exporter/pull/1442) - Implement a Windows application manifest by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1445](https://togithub.com/prometheus-community/windows_exporter/pull/1445) - Ability to disable debug endpoints by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1448](https://togithub.com/prometheus-community/windows_exporter/pull/1448) - Do not add "--web.listen-address" to service if default values are provided by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1452](https://togithub.com/prometheus-community/windows_exporter/pull/1452) - iis: Add IIS info metric by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1450](https://togithub.com/prometheus-community/windows_exporter/pull/1450) - perflib: enrich error message by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1460](https://togithub.com/prometheus-community/windows_exporter/pull/1460) - Remove landing page by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1471](https://togithub.com/prometheus-community/windows_exporter/pull/1471) - Remove unused `*prometheus.Desc` return value from collectors `collect()` function by [@​breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1475](https://togithub.com/prometheus-community/windows_exporter/pull/1475) - Implementing smbclient collector by [@​rob-scheepens](https://togithub.com/rob-scheepens) in [https://github.com/prometheus-community/windows_exporter/pull/1408](https://togithub.com/prometheus-community/windows_exporter/pull/1408) - Add: push docker images to dockerhub by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1469](https://togithub.com/prometheus-community/windows_exporter/pull/1469) - scheduled_task: Move OLE connection to collect function by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1451](https://togithub.com/prometheus-community/windows_exporter/pull/1451) - Enable process V1 performance counters by default by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1477](https://togithub.com/prometheus-community/windows_exporter/pull/1477) - Add new RemoteFX network metrics by [@​truck0321](https://togithub.com/truck0321) in [https://github.com/prometheus-community/windows_exporter/pull/1489](https://togithub.com/prometheus-community/windows_exporter/pull/1489) - Add Printer Exporter by [@​soheilrt](https://togithub.com/soheilrt) in [https://github.com/prometheus-community/windows_exporter/pull/1485](https://togithub.com/prometheus-community/windows_exporter/pull/1485) - feat: allow setting of exporter process priority by [@​breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1488](https://togithub.com/prometheus-community/windows_exporter/pull/1488) - Fix omission of RemoteFX Graphics metrics by [@​benash](https://togithub.com/benash) in [https://github.com/prometheus-community/windows_exporter/pull/1511](https://togithub.com/prometheus-community/windows_exporter/pull/1511) - Fix timezone caching issues by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1499](https://togithub.com/prometheus-community/windows_exporter/pull/1499) - Service V2 collector by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1497](https://togithub.com/prometheus-community/windows_exporter/pull/1497) - Add label user to process collector by [@​aburtasov](https://togithub.com/aburtasov) in [https://github.com/prometheus-community/windows_exporter/pull/1472](https://togithub.com/prometheus-community/windows_exporter/pull/1472) - Update collector.diskdrive.md by [@​jacbo0112](https://togithub.com/jacbo0112) in [https://github.com/prometheus-community/windows_exporter/pull/1502](https://togithub.com/prometheus-community/windows_exporter/pull/1502) - fix(README.md): Corrected image links by [@​FRFlo](https://togithub.com/FRFlo) in [https://github.com/prometheus-community/windows_exporter/pull/1533](https://togithub.com/prometheus-community/windows_exporter/pull/1533) - Add hostprocess image builds by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1507](https://togithub.com/prometheus-community/windows_exporter/pull/1507) - fix default value of collectors.dfsr.sources-enabled by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1506](https://togithub.com/prometheus-community/windows_exporter/pull/1506) - logical disk: Fix metrics for non drive letter disks by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1498](https://togithub.com/prometheus-community/windows_exporter/pull/1498) - printer collector: Use ENUM pattern for printer status by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1500](https://togithub.com/prometheus-community/windows_exporter/pull/1500) - license collector by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1524](https://togithub.com/prometheus-community/windows_exporter/pull/1524) - Add terminal service session info by [@​jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1525](https://togithub.com/prometheus-community/windows_exporter/pull/1525) #### New Contributors - [@​Winter-py](https://togithub.com/Winter-py) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1409](https://togithub.com/prometheus-community/windows_exporter/pull/1409) - [@​jaco-van-zyl-derivco](https://togithub.com/jaco-van-zyl-derivco) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1416](https://togithub.com/prometheus-community/windows_exporter/pull/1416) - [@​simon04](https://togithub.com/simon04) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1401](https://togithub.com/prometheus-community/windows_exporter/pull/1401) - [@​webalexeu](https://togithub.com/webalexeu) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1395](https://togithub.com/prometheus-community/windows_exporter/pull/1395) - [@​truck0321](https://togithub.com/truck0321) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1489](https://togithub.com/prometheus-community/windows_exporter/pull/1489) - [@​jacbo0112](https://togithub.com/jacbo0112) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1495](https://togithub.com/prometheus-community/windows_exporter/pull/1495) - [@​soheilrt](https://togithub.com/soheilrt) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1485](https://togithub.com/prometheus-community/windows_exporter/pull/1485) - [@​benash](https://togithub.com/benash) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1511](https://togithub.com/prometheus-community/windows_exporter/pull/1511) - [@​FRFlo](https://togithub.com/FRFlo) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1533](https://togithub.com/prometheus-community/windows_exporter/pull/1533) **Full Changelog**: prometheus-community/windows_exporter@v0.25.1...v0.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjI2LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
…rter to v0.27.1 (open-telemetry#34332) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus-community/windows_exporter](https://togithub.com/prometheus-community/windows_exporter) | `v0.25.1` -> `v0.27.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus-community%2fwindows_exporter/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus-community%2fwindows_exporter/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus-community%2fwindows_exporter/v0.25.1/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus-community%2fwindows_exporter/v0.25.1/v0.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus-community/windows_exporter (github.com/prometheus-community/windows_exporter)</summary> ### [`v0.27.1`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.27.1) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.27.0...v0.27.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 🐞 Bug Fixes - mssql: fix nil panic, if YAML file is used a configuration by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1570](https://togithub.com/prometheus-community/windows_exporter/pull/1570) ##### 🛠️ Dependencies - chore(deps): bump golang.org/x/sys from 0.23.0 to 0.24.0 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1566](https://togithub.com/prometheus-community/windows_exporter/pull/1566) **Full Changelog**: prometheus-community/windows_exporter@v0.27.0...v0.27.1 ### [`v0.27.0`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.27.0) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.26.2...v0.27.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 💥 Breaking Changes - textfile: disable collector by default by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1560](https://togithub.com/prometheus-community/windows_exporter/pull/1560) - chore: Refactor Config Collector API by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1558](https://togithub.com/prometheus-community/windows_exporter/pull/1558) - cleanup collector APIs 1 by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1547](https://togithub.com/prometheus-community/windows_exporter/pull/1547) ##### ✨ Exciting New Features - chore: deprecate teradici_pcoip and vmware_blast collector by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1559](https://togithub.com/prometheus-community/windows_exporter/pull/1559) ##### 🐞 Bug Fixes - installer: do not enable V1 counters by default by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1555](https://togithub.com/prometheus-community/windows_exporter/pull/1555) - scheduled_task: do not report windows_scheduled_task_last_result for task that never run before by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1562](https://togithub.com/prometheus-community/windows_exporter/pull/1562) ##### 🛠️ Dependencies - chore(deps): bump actions/checkout from 3 to 4 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1550](https://togithub.com/prometheus-community/windows_exporter/pull/1550) - chore(deps): bump golang.org/x/sys from 0.22.0 to 0.23.0 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1549](https://togithub.com/prometheus-community/windows_exporter/pull/1549) **Full Changelog**: prometheus-community/windows_exporter@v0.26.2...v0.27.0 ### [`v0.26.2`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.26.2) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.26.1...v0.26.2) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 🐞 Bug Fixes - printer: expose config struct properties by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1545](https://togithub.com/prometheus-community/windows_exporter/pull/1545) - terminal_services: Fix "The operation completed successfully." error by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1548](https://togithub.com/prometheus-community/windows_exporter/pull/1548) **Full Changelog**: prometheus-community/windows_exporter@v0.26.1...v0.26.2 ### [`v0.26.1`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.26.1) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.26.0...v0.26.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### 🐞 Bug Fixes - fix: CPU Collector % Cx Time mismatch by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1542](https://togithub.com/prometheus-community/windows_exporter/pull/1542) - logical_disk: Fix failed to get disk ID for dynamic volumes by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1544](https://togithub.com/prometheus-community/windows_exporter/pull/1544) ##### 🛠️ Dependencies - chore(deps): bump actions/stale from 8 to 9 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus-community/windows_exporter/pull/1541](https://togithub.com/prometheus-community/windows_exporter/pull/1541) **Full Changelog**: prometheus-community/windows_exporter@v0.26.0...v0.26.1 ### [`v0.26.0`](https://togithub.com/prometheus-community/windows_exporter/releases/tag/v0.26.0) [Compare Source](https://togithub.com/prometheus-community/windows_exporter/compare/v0.25.1...v0.26.0) #### What's Changed - fix([#&open-telemetry#8203;1390](https://togithub.com/prometheus-community/windows_exporter/issues/1390)): global kingpin instead of app var by [@&open-telemetry#8203;DiniFarb](https://togithub.com/DiniFarb) in [https://github.com/prometheus-community/windows_exporter/pull/1397](https://togithub.com/prometheus-community/windows_exporter/pull/1397) - docs!: Remove support for EOL Windows versions by [@&open-telemetry#8203;breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1396](https://togithub.com/prometheus-community/windows_exporter/pull/1396) - Fix collector.process.iis flag by [@&open-telemetry#8203;jaco-van-zyl-derivco](https://togithub.com/jaco-van-zyl-derivco) in [https://github.com/prometheus-community/windows_exporter/pull/1416](https://togithub.com/prometheus-community/windows_exporter/pull/1416) - fix: Apply query filter to metrics by [@&open-telemetry#8203;breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1392](https://togithub.com/prometheus-community/windows_exporter/pull/1392) - Restore Windows 2012 support. by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1446](https://togithub.com/prometheus-community/windows_exporter/pull/1446) - installer: Disable Windows Firewall Exception by default. Can be re-enabled with ADD_FIREWALL_EXCEPTION=yes by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1447](https://togithub.com/prometheus-community/windows_exporter/pull/1447) - Improvement: Add owner_node on resource and resourcegroup for mscluster by [@&open-telemetry#8203;webalexeu](https://togithub.com/webalexeu) in [https://github.com/prometheus-community/windows_exporter/pull/1395](https://togithub.com/prometheus-community/windows_exporter/pull/1395) - Add label volume_name to logical_disk collector by [@&open-telemetry#8203;aburtasov](https://togithub.com/aburtasov) in [https://github.com/prometheus-community/windows_exporter/pull/1442](https://togithub.com/prometheus-community/windows_exporter/pull/1442) - Implement a Windows application manifest by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1445](https://togithub.com/prometheus-community/windows_exporter/pull/1445) - Ability to disable debug endpoints by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1448](https://togithub.com/prometheus-community/windows_exporter/pull/1448) - Do not add "--web.listen-address" to service if default values are provided by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1452](https://togithub.com/prometheus-community/windows_exporter/pull/1452) - iis: Add IIS info metric by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1450](https://togithub.com/prometheus-community/windows_exporter/pull/1450) - perflib: enrich error message by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1460](https://togithub.com/prometheus-community/windows_exporter/pull/1460) - Remove landing page by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1471](https://togithub.com/prometheus-community/windows_exporter/pull/1471) - Remove unused `*prometheus.Desc` return value from collectors `collect()` function by [@&open-telemetry#8203;breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1475](https://togithub.com/prometheus-community/windows_exporter/pull/1475) - Implementing smbclient collector by [@&open-telemetry#8203;rob-scheepens](https://togithub.com/rob-scheepens) in [https://github.com/prometheus-community/windows_exporter/pull/1408](https://togithub.com/prometheus-community/windows_exporter/pull/1408) - Add: push docker images to dockerhub by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1469](https://togithub.com/prometheus-community/windows_exporter/pull/1469) - scheduled_task: Move OLE connection to collect function by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1451](https://togithub.com/prometheus-community/windows_exporter/pull/1451) - Enable process V1 performance counters by default by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1477](https://togithub.com/prometheus-community/windows_exporter/pull/1477) - Add new RemoteFX network metrics by [@&open-telemetry#8203;truck0321](https://togithub.com/truck0321) in [https://github.com/prometheus-community/windows_exporter/pull/1489](https://togithub.com/prometheus-community/windows_exporter/pull/1489) - Add Printer Exporter by [@&open-telemetry#8203;soheilrt](https://togithub.com/soheilrt) in [https://github.com/prometheus-community/windows_exporter/pull/1485](https://togithub.com/prometheus-community/windows_exporter/pull/1485) - feat: allow setting of exporter process priority by [@&open-telemetry#8203;breed808](https://togithub.com/breed808) in [https://github.com/prometheus-community/windows_exporter/pull/1488](https://togithub.com/prometheus-community/windows_exporter/pull/1488) - Fix omission of RemoteFX Graphics metrics by [@&open-telemetry#8203;benash](https://togithub.com/benash) in [https://github.com/prometheus-community/windows_exporter/pull/1511](https://togithub.com/prometheus-community/windows_exporter/pull/1511) - Fix timezone caching issues by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1499](https://togithub.com/prometheus-community/windows_exporter/pull/1499) - Service V2 collector by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1497](https://togithub.com/prometheus-community/windows_exporter/pull/1497) - Add label user to process collector by [@&open-telemetry#8203;aburtasov](https://togithub.com/aburtasov) in [https://github.com/prometheus-community/windows_exporter/pull/1472](https://togithub.com/prometheus-community/windows_exporter/pull/1472) - Update collector.diskdrive.md by [@&open-telemetry#8203;jacbo0112](https://togithub.com/jacbo0112) in [https://github.com/prometheus-community/windows_exporter/pull/1502](https://togithub.com/prometheus-community/windows_exporter/pull/1502) - fix(README.md): Corrected image links by [@&open-telemetry#8203;FRFlo](https://togithub.com/FRFlo) in [https://github.com/prometheus-community/windows_exporter/pull/1533](https://togithub.com/prometheus-community/windows_exporter/pull/1533) - Add hostprocess image builds by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1507](https://togithub.com/prometheus-community/windows_exporter/pull/1507) - fix default value of collectors.dfsr.sources-enabled by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1506](https://togithub.com/prometheus-community/windows_exporter/pull/1506) - logical disk: Fix metrics for non drive letter disks by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1498](https://togithub.com/prometheus-community/windows_exporter/pull/1498) - printer collector: Use ENUM pattern for printer status by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1500](https://togithub.com/prometheus-community/windows_exporter/pull/1500) - license collector by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1524](https://togithub.com/prometheus-community/windows_exporter/pull/1524) - Add terminal service session info by [@&open-telemetry#8203;jkroepke](https://togithub.com/jkroepke) in [https://github.com/prometheus-community/windows_exporter/pull/1525](https://togithub.com/prometheus-community/windows_exporter/pull/1525) #### New Contributors - [@&open-telemetry#8203;Winter-py](https://togithub.com/Winter-py) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1409](https://togithub.com/prometheus-community/windows_exporter/pull/1409) - [@&open-telemetry#8203;jaco-van-zyl-derivco](https://togithub.com/jaco-van-zyl-derivco) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1416](https://togithub.com/prometheus-community/windows_exporter/pull/1416) - [@&open-telemetry#8203;simon04](https://togithub.com/simon04) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1401](https://togithub.com/prometheus-community/windows_exporter/pull/1401) - [@&open-telemetry#8203;webalexeu](https://togithub.com/webalexeu) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1395](https://togithub.com/prometheus-community/windows_exporter/pull/1395) - [@&open-telemetry#8203;truck0321](https://togithub.com/truck0321) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1489](https://togithub.com/prometheus-community/windows_exporter/pull/1489) - [@&open-telemetry#8203;jacbo0112](https://togithub.com/jacbo0112) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1495](https://togithub.com/prometheus-community/windows_exporter/pull/1495) - [@&open-telemetry#8203;soheilrt](https://togithub.com/soheilrt) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1485](https://togithub.com/prometheus-community/windows_exporter/pull/1485) - [@&open-telemetry#8203;benash](https://togithub.com/benash) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1511](https://togithub.com/prometheus-community/windows_exporter/pull/1511) - [@&open-telemetry#8203;FRFlo](https://togithub.com/FRFlo) made their first contribution in [https://github.com/prometheus-community/windows_exporter/pull/1533](https://togithub.com/prometheus-community/windows_exporter/pull/1533) **Full Changelog**: prometheus-community/windows_exporter@v0.25.1...v0.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjI2LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de>
Added label "user" to process collector. Using WIN32_LoggedOnUser and Win32_SessionProcess
Example metric with new label:
HELP windows_process_cpu_time_total Returns elapsed time that all of the threads of this process used the processor to execute instructions by mode (privileged, user).
TYPE windows_process_cpu_time_total counter
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="17512",user="MYDOMAIN\aburtasov"} 0.296875
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="19688",user="MYDOMAIN\aburtasov"} 14.296875
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="25612",user="MYDOMAIN\aburtasov"} 0.484375