Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize common files from prometheus/prometheus #1636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prombot
Copy link
Collaborator

@prombot prombot commented Sep 22, 2024

Propagating changes from prometheus/prometheus default branch.

Signed-off-by: prombot <prometheus-team@googlegroups.com>
@prombot prombot requested a review from a team as a code owner September 22, 2024 17:48
@jkroepke jkroepke added the chore routine maintenance tasks label Sep 22, 2024
@jkroepke
Copy link
Member

jkroepke commented Oct 2, 2024

@SuperQ Would it be possible to share the quay.io credentials with prometheus-community org?

Than, we can publish images to quay.io as well and the README sync should not longer fail.

@SuperQ
Copy link
Contributor

SuperQ commented Oct 2, 2024

Hmmm, I thought I added the credentials to prometheus-community CI already. Let me take a look.

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, the secret is already in the org level actions secret store. This should just work .

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke force-pushed the repo_sync branch 2 times, most recently from f78c3bd to f9b5ae6 Compare October 3, 2024 08:40
@jkroepke
Copy link
Member

jkroepke commented Oct 3, 2024

@SuperQ At the repository settings, I can only observe QUAY_IO_API_TOKEN - which can be used for API requests like syncing the READE.md.

But like on prometheus/prometheus repository, I also need username and password to push image. I can't see it. Could it be possible that the secret is set on org level, but not granted to windows_exporter?

Thats, what I see

image

https://github.com/prometheus-community/windows_exporter/settings/secrets/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore routine maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants