Set Windows versioninfo on build #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://www.linuxfoundation.org/trademark-usage/ is the relevant policy, and reading through it "A logo should not be displayed with color variations, or with other elements superimposed on top of the logo.". |
|
Thanks for adding the version info! |
|
It also shows in appwiz.cpl so might not be a bad idea to add an icon to make it look complete. |
Signed-off-by: Calle Pettersson <carlpett@users.noreply.github.com>
carlpett
force-pushed
the
set-versioninfo
branch
from
4030bb6 to
51dd61b
Compare
carlpett
changed the title
|
I reached out to the CNCF trademark team back in July but still haven't heard back, so ditching the logo thing. |
|
Ok, great! If at some point they reach back to you we can still add it back. |
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…/set-versioninfo Set Windows versioninfo on build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds versioninfo generation for the .exe to the build steps, meaning checking the file properties will now look like this:
I also had a moment of inspiration when I saw the field for the icon, so I also threw together the below and if people think it looks okay, it will be the icon for the exe and in Add/Remove programs:
(@brian-brazil - I couldn't find any separate license/usage guidelines for the Prometheus logo and my understanding is that this type of derivative work is fine, correct?)
Fixes #561