Use the new prometheus http API

[juergenhoetzel]

prometheus/client_golang#214

Thanks for this package! 👍

[carlpett]

Hi @juergenhoetzel, thanks for the PR! The build fails because of missing vendoring, could you add promhttp as a vendored package?

[martinlindhe]

@juergenhoetzel Good work! For the pr to land, you'll also need to commit the changes in vendor, because it is still failing on missing promhttp. Appveyour output: https://ci.appveyor.com/project/martinlindhe/wmi-exporter/build/258/job/x5ucqsbxku8huu96

govendor test -v +local
exporter.go:18:2: cannot find package "github.com/prometheus/client_golang/prometheus/promhttp" in any of:
	c:\gopath\src\github.com\martinlindhe\wmi_exporter\vendor\github.com\prometheus\client_golang\prometheus\promhttp (vendor tree)
	C:\go\src\github.com\prometheus\client_golang\prometheus\promhttp (from $GOROOT)
	c:\gopath\src\github.com\prometheus\client_golang\prometheus\promhttp (from $GOPATH)
Error: exit status 1

[martinlindhe]

Not sure this is correct.
log.Fatal() simply exits the program. You'll still need to do as before, that is checking for error.

[juergenhoetzel]

Hi @martinlindhe
http.ListenAndServer only returns when an error occured. I.e. it never returns nil. This style is also used in the official Go http documentation

[martinlindhe]

Ah, that's all good then! I was under the wrong impression it was non-blocking

[martinlindhe]

This is wrong. We do version the vendor folder.

[martinlindhe]

This is wrong. We commit the vendor folder for reproducible builds.

[juergenhoetzel]

@juergenhoetzel Good work! For the pr to land, you'll also need to commit the changes in vendor, because it is still failing on missing promhttp. Appveyour output: https://ci.appveyor.com/project/martinlindhe/wmi-exporter/build/258/job/x5ucqsbxku8huu96

@martinlindhe Thanks for the hint. I didn't used govendor before. I removed all vendored sources and and used the sync functionality instead: https://github.com/kardianos/govendor .

[martinlindhe]

@juergenhoetzel For vendoring, all you need to do is, manually

govendor sync
git add vendor
git commit -am "updated vendored dependencies"

This gives us a working snapshot of correct vendored dependencies,
so we have reproducible builds.
We don't want this step to happen in appveyor at a later time, when deps might have changed, and we don't want the vendor folder gitignored.

[juergenhoetzel]

This gives us a working snapshot of correct vendored dependencies,
so we have reproducible builds.
We don't want this step to happen in appveyor at a later time, when deps might have changed, and we don't want the vendor folder gitignored.

Make sense. I will revert/amend the change.

[martinlindhe]

Feel free to just commit additional changes to this branch (if that is less work), we can merge the PR as a single commit when done

[martinlindhe]

I seem to have forgotten how to use govendor.

I think the proper usage is something like:

govendor fetch github.com/prometheus/client_golang/prometheus/promhttp
git add vendor
git commit -am "updated vendored dependencies"

[juergenhoetzel]

I seem to have forgotten how to use govendor.

I think the proper usage is something like:

govendor fetch github.com/prometheus/client_golang/prometheus/promhttp
git add vendor
git commit -am "updated vendored dependencies"

Thanks for your feedback. I actually used

govendor.exe fetch github.com/prometheus/client_golang/prometheus/...

to update all referenced packages under the prometheus path.

What started as an small prometheus API update ended in an excursion to the go package dependency nightmare 😨

😆

[martinlindhe]

Thanks for your work, looks good!