Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to install tools with go install rather than go get #753

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

carlpett
Copy link
Collaborator

No description provided.

@carlpett carlpett requested a review from a team as a code owner March 24, 2021 16:02
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Not sure what's going on with the CI, is that unrelated to the change?

Signed-off-by: Calle Pettersson <calle@cape.nu>
@carlpett
Copy link
Collaborator Author

AppVeyor seems to have bumped to Go 1.16, where non-modules mode is no longer supported. And this meant that how we installed promu broke.
Apparently my first attempted patch ran into Powershell interpreting stderr as actual errors. Trying again with running in cmd instead...

@carlpett
Copy link
Collaborator Author

Looks better now. The fact that the environment can change under our feet isn't great though.

@carlpett carlpett merged commit 6dee242 into master Mar 28, 2021
@carlpett carlpett deleted the fix-ci branch March 28, 2021 08:41
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
…/fix-ci

Update CI to install tools with go install rather than go get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants