Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated log lib in remaining collectors #802

Merged
merged 2 commits into from
Jun 12, 2021
Merged

Replace deprecated log lib in remaining collectors #802

merged 2 commits into from
Jun 12, 2021

Conversation

breed808
Copy link
Contributor

Some collectors were missed when migrating to the local github.com/prometheus-community/windows_exporter/log library.

Resolves #801

@breed808 breed808 requested a review from a team as a code owner June 12, 2021 01:57
breed808 added 2 commits June 12, 2021 11:57
Some collectors were missed when migrating to the local
github.com/prometheus-community/windows_exporter/log library.

Signed-off-by: Ben Reedy <breed808@breed808.com>
Signed-off-by: Ben Reedy <breed808@breed808.com>
Copy link
Collaborator

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops 😰
Nice find!

@breed808 breed808 merged commit 2bc3c18 into prometheus-community:master Jun 12, 2021
@breed808 breed808 deleted the log_dependency branch June 12, 2021 09:52
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
Replace deprecated log lib in remaining collectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error: cannot find module providing package github.com/prometheus/common/log
2 participants