Update dependencies #862
Update dependencies #862
Conversation
External log package has been extracted to a separate external repository and module. Signed-off-by: Ben Reedy <breed808@breed808.com>
Signed-off-by: Ben Reedy <breed808@breed808.com>
Signed-off-by: Ben Reedy <breed808@breed808.com>
|
There are others that are out of date too (hcsshim as example)? Should those be updated too? |
|
It's a good point, but perhaps we can do that as a separate PR? This one to bump the "prometheus-shared", then others for other bits. Makes it somewhat easier to understand what broke, if anything does :) |
|
makes sense! I was also wondering about the go version. The mod file specifies 1.13: Line 3 in ce3d517 |
|
I had intended a separate PR to propose adding Dependabot to the project to semi-automate dependency updating. I missed the hcsshim dependencies (and likely others), I don't mind adding them here or in another PR. Docs for the go.mod file state the version is a minimum version:
So my thinking was to leave it at 1.13 rather than arbitrarily increasing the version requirement. Happy to be wrong about this though! |
thanks for the explanation, I was looking for the correct golang version to build it in for #864 and noticed this |
|
lgtm |
Update dependencies
Update project dependencies, notably go-kit/kit, which was responsible for a number of out-of-date dependencies.