codespell: add GH Action for checking spelling issues #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this! I'm thinking we can get #898 reviewed and merged first, then integrate this as a job in the new CI/CD configuration. |
|
There are different approaches, one having only one big config file and other having many smaller ones. Maybe we can split it in build and linting jobs, but both cases are fine for me. |
|
I'm fine with either method as well, so long as dependencies between files can be specified (I.E. build requires lint/testspellcheck jobs to pass before starting).
…-------- Original Message --------
On 30 Dec 2021, 21:16, Mario Trangoni wrote:
There are different approaches, one having only one big config file and other having many smaller ones.
Maybe we can split it in build and linting jobs, but both cases are fine for me.
—
Reply to this email directly, [view it on GitHub](#896 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAXVYSPKBBG3YU7SJEXI55TUTQ5PFANCNFSM5K5VVW2A).
Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Good point!, and it seems this is possible with workflow_run |
|
@mjtrangoni #898 has been merged, you can rebase this PR on |
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
mjtrangoni
force-pushed
the
add-codespell
branch
from
c08a101 to
a8eefae
Compare
|
@breed808 PTAL |
breed808
approved these changes
Jan 2, 2022
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…pell codespell: add GH Action for checking spelling issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carlpett @breed808,
This add a GH Action for checking spelling issues detected by codespell. As I fixed all of them already at #892, this will prevent us for adding new ones.