Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ADFS metrics from AD FS CounterSet #909

Merged

Conversation

akrauza
Copy link
Contributor

@akrauza akrauza commented Jan 4, 2022

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

Reformat adfsCollector struct

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

Add metrics to ADFS collector documentation

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

Update ADFS collector with useful queries and links to documentation

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

Remove bad table formatter

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

Reformat ADFS collector using gofmt

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

Fix ADFS Config and Artifact DB Query time metrics

Signed-off-by: Austin D. Krauza krauza.austin@gmail.com

@akrauza akrauza requested a review from a team as a code owner January 4, 2022 22:17
@akrauza
Copy link
Contributor Author

akrauza commented Jan 10, 2022

Hi @carlpett @breed808. This is ready for review. Thanks!

Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing this Austin! I must have erroneously marked this as "read" without responding.

I've identified a discrepancy with two of the new metrics, have a look into those two and then we should be OK to merge 👍

collector/adfs.go Outdated Show resolved Hide resolved
collector/adfs.go Outdated Show resolved Hide resolved
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Austin, just one minor change to the metric descriptions and we're good to go.

collector/adfs.go Outdated Show resolved Hide resolved
collector/adfs.go Outdated Show resolved Hide resolved
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Reformat adfsCollector struct

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Add metrics to ADFS collector documentation

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Update ADFS collector with useful queries and links to documentation

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Remove bad table formatter

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Reformat ADFS collector using gofmt

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Fix ADFS Config and Artifact DB Query time metrics

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Update ADFS collector for Config and Artifact DB Query time from gauge to counter

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>

Update ADFS collector for Config and Artifact DB Query time from gauge to counter

Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
@akrauza akrauza force-pushed the more-adfs-metrics-again branch from 4c2db5b to 2ed0ae8 Compare January 10, 2022 22:27
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for making the requested changes for this, it's much appreciated.

@breed808 breed808 merged commit ce205d4 into prometheus-community:master Jan 10, 2022
@akrauza
Copy link
Contributor Author

akrauza commented Jan 10, 2022

Anytime!!

anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
…trics-again

Add more ADFS metrics from `AD FS` CounterSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants