-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ADFS metrics from AD FS
CounterSet
#909
Add more ADFS metrics from AD FS
CounterSet
#909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for missing this Austin! I must have erroneously marked this as "read" without responding.
I've identified a discrepancy with two of the new metrics, have a look into those two and then we should be OK to merge 👍
52be1ed
to
4c2db5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Austin, just one minor change to the metric descriptions and we're good to go.
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Reformat adfsCollector struct Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Add metrics to ADFS collector documentation Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Update ADFS collector with useful queries and links to documentation Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Remove bad table formatter Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Reformat ADFS collector using gofmt Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Fix ADFS Config and Artifact DB Query time metrics Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Update ADFS collector for Config and Artifact DB Query time from gauge to counter Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com> Update ADFS collector for Config and Artifact DB Query time from gauge to counter Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
4c2db5b
to
2ed0ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks for making the requested changes for this, it's much appreciated.
Anytime!! |
…trics-again Add more ADFS metrics from `AD FS` CounterSet
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com
Reformat adfsCollector struct
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com
Add metrics to ADFS collector documentation
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com
Update ADFS collector with useful queries and links to documentation
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com
Remove bad table formatter
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com
Reformat ADFS collector using gofmt
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com
Fix ADFS Config and Artifact DB Query time metrics
Signed-off-by: Austin D. Krauza krauza.austin@gmail.com