-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hyper-V VM Memory metrics #971
Add Hyper-V VM Memory metrics #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this! There's some changes required for the metric names & descriptions, but overall this is looking good 👍
Aside from the review comments, you'll also need to sign off on the commit (see the link next to the failed action for info). It'd be a good idea to rebase your feature branch to pick up recent CI fixes too. |
Signed-off-by: Andrew Banman <abanman@pnri.org>
Signed-off-by: Andrew Banman <abanman@pnri.org>
Signed-off-by: Andrew Banman <abanman@pnri.org>
Remove "memory", which is redundant with the module and breaks symmetry with vm_memory_physical_guest_visible. Signed-off-by: Andrew Banman <abanman@pnri.org>
Signed-off-by: Andrew Banman <abanman@pnri.org>
Signed-off-by: Andrew Banman <abanman@pnri.org>
Signed-off-by: Ben Reedy <breed808@breed808.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is looking good. I've added initial documentation entries for the memory metrics as well.
Thank you for taking the time to review and for the helpful suggestions. I'm working on relevant alerts and a Grafana dashboard that I plan to share soon. |
…vm_memory Add Hyper-V VM Memory metrics
Add
Win32_PerfRawData_BalancerStats_HyperVDynamicMemoryVM
WMI class to monitor VM memory. The class shows metrics for VMs with and without dynamic memory enabled.This partially addresses #574 #517
Example output: