Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace these deprecated functions #982

Merged
merged 1 commit into from
May 15, 2022
Merged

replace these deprecated functions #982

merged 1 commit into from
May 15, 2022

Conversation

yangliyl
Copy link
Contributor

replace these prometheus deprecated functions

@yangliyl yangliyl requested a review from a team as a code owner April 29, 2022 01:19
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! You'll need to rebase the feature branch to pick up some recent CI fixes.

@yangliyl
Copy link
Contributor Author

Is it okay now? @breed808

@breed808
Copy link
Contributor

I think something's gone wrong in the rebase; the PR is attempting to merge all recent commits rather than the previous single commit.

When switched to your feature branch, does git rebase master make any changes? Alternatively you can run git rebase -i master to perform the rebase interactively.

Signed-off-by: yangliyl <yangli_yl@qq.com>
@breed808
Copy link
Contributor

Thanks, that's looking good now 👍

@breed808 breed808 merged commit fd36eae into prometheus-community:master May 15, 2022
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
…-functions

replace these deprecated functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants