This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Add test for out-of-order datapoints #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the existing `TestAmendDatapointCausesError` test, assert that `ErrOutOfOrderSample` is returned if we try to append a sample older than the most recent sample for a given series.
mattbostock
force-pushed
the
add_out_of_order_test
branch
from
697adea
to
3c90eac
Compare
|
Hmm, what is interesting is that adding a OOO sample in the same appender gives no error! We silently drop it, not sure if we want that to be the behaviour. @fabxc, your thoughts? |
|
That should return an error I'd say. |
|
superseded in : #387 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing
TestAmendDatapointCausesErrortest, assertthat
ErrOutOfOrderSampleis returned if we try to append a sampleolder than the most recent sample for a given series.