Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

add function to retreive index's section memory size and use this to get symbol table size #272

Closed
wants to merge 4 commits into from
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions index/index.go
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,27 @@ func (r *Reader) decbufUvarintAt(off int) decbuf {
return dec
}

// getSectionSize returns the first 4 bytes in a section starting at offset off
// to get the content length bytes
func (r *Reader) getSectionSize(off int) int {
if off == 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this check.

return 0
}
b := r.b.Range(off, off+4)
var l int
if l <= 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, l has just been declared hence will always be 0.

l = -1
} else {
l = int(binary.BigEndian.Uint32(b))
}
return l
}

// getSymbolTableSize returns the bytes taken by the symbol table of Reader object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end comments with .

func (r *Reader) getSymbolTableSize(off int) int {
return r.getSectionSize(int(r.toc.symbols))
}

// readSymbols reads the symbol table fully into memory and allocates proper strings for them.
// Strings backed by the mmap'd memory would cause memory faults if applications keep using them
// after the reader is closed.
Expand Down