This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 180
add function to retreive index's section memory size and use this to get symbol table size #272
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2802ecd
add function to retreive index's section memory size and use this to …
sipian 35e1a14
fix compliation issues for getSectionSize function
sipian be1da31
expose metric and add getSymbolTableSize function in IndexReader int…
sipian 0fe6bf5
Merge branch 'master' of github.com:prometheus/tsdb into symboltable-…
sipian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -743,6 +743,27 @@ func (r *Reader) decbufUvarintAt(off int) decbuf { | |
return dec | ||
} | ||
|
||
// getSectionSize returns the first 4 bytes in a section starting at offset off | ||
// to get the content length bytes | ||
func (r *Reader) getSectionSize(off int) int { | ||
if off == 0 { | ||
return 0 | ||
} | ||
b := r.b.Range(off, off+4) | ||
var l int | ||
if l <= 0 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Umm, |
||
l = -1 | ||
} else { | ||
l = int(binary.BigEndian.Uint32(b)) | ||
} | ||
return l | ||
} | ||
|
||
// getSymbolTableSize returns the bytes taken by the symbol table of Reader object | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. end comments with |
||
func (r *Reader) getSymbolTableSize(off int) int { | ||
return r.getSectionSize(int(r.toc.symbols)) | ||
} | ||
|
||
// readSymbols reads the symbol table fully into memory and allocates proper strings for them. | ||
// Strings backed by the mmap'd memory would cause memory faults if applications keep using them | ||
// after the reader is closed. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this check.