This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Remove _total from prometheus_tsdb_storage_blocks_bytes #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe also update and add this to the CHANGELOG |
|
Those are counters, so there's no need to change them. |
|
ok I am not that familiar with the naming convention so will leave it to you. LGTM |
|
A CHANGELOG entry and we should be good to go. |
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil
force-pushed
the
blocks-metric
branch
from
93b38bb to
b7a602b
Compare
|
Done |
codesome
reviewed
Jan 23, 2019
| @@ -10,6 +12,7 @@ | |||
| - [REMOVED] `PrefixMatcher` is considered unused so was removed. | |||
| - [CLEANUP] `Options.WALFlushInterval` is removed as it wasn't used anywhere. | |||
| - [FEATURE] Add new `LiveReader` to WAL pacakge. Added to allow live tailing of a WAL segment, used by Prometheus Remote Write after refactor. The main difference between the new reader and the existing `Reader` is that for `LiveReader` a call to `Next()` that returns false does not mean that there will never be more data to read. | |||
| - [CHANGE] Empty blocks are not written during compaction [#374](https://github.com/prometheus/tsdb/pull/374) | |||
There was a problem hiding this comment.
Suggested change
| - [CHANGE] Empty blocks are not written during compaction [#374](https://github.com/prometheus/tsdb/pull/374) |
There was a problem hiding this comment.
oo shoot I missed that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian Brazil brian.brazil@robustperception.io