Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] adding analyze operator cmd docs #33

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

nicolastakashi
Copy link
Collaborator

This pull request includes significant updates to the Documentation/commands/analyze/index.md file to enhance the documentation around the analyze command, particularly in the context of the Prometheus Operator. The most important changes include the addition of sections detailing the analyze command's functionality, the rules it evaluates, and specific requirements for the Prometheus Operator deployment.

Enhancements to Documentation:

  • Analyze Operator Section: Added a new section explaining how the analyze command can target the Prometheus Operator deployment within a Kubernetes cluster, including specifying the namespace and name of the Prometheus Operator. ([Documentation/commands/analyze/index.mdR44-R61](https://github.com/prometheus-operator/poctl/pull/33/files#diff-975e48a917fb0aacf8b99f389b853b76ce598e680cf7cf369e4717b8313431deR44-R61))
  • Rules Section: Introduced a section that outlines the rules evaluated by the analyze command, which are defined in the analyzer package and implemented in the internal/analyzer/operator.go file. ([Documentation/commands/analyze/index.mdR44-R61](https://github.com/prometheus-operator/poctl/pull/33/files#diff-975e48a917fb0aacf8b99f389b853b76ce598e680cf7cf369e4717b8313431deR44-R61))
  • Operator Existence Rule: Added a rule stating that the Prometheus Operator deployment must exist in the Kubernetes cluster. ([Documentation/commands/analyze/index.mdR44-R61](https://github.com/prometheus-operator/poctl/pull/33/files#diff-975e48a917fb0aacf8b99f389b853b76ce598e680cf7cf369e4717b8313431deR44-R61))
  • RBAC Rules Section: Detailed the RBAC (Role-Based Access Control) rules necessary for the Prometheus Operator deployment to function correctly, specifying the required permissions for the service account associated with the Prometheus Operator. ([Documentation/commands/analyze/index.mdR44-R61](https://github.com/prometheus-operator/poctl/pull/33/files#diff-975e48a917fb0aacf8b99f389b853b76ce598e680cf7cf369e4717b8313431deR44-R61))

@nicolastakashi nicolastakashi force-pushed the docs/adding-analyze-operator-command branch from d87e235 to 145ff36 Compare September 10, 2024 10:21

### Operator Existence

The Prometheus Operator deployment must exist in the Kubernetes cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain how that is done? The sentence here sounds pretty vague

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!
Wdyt about the new version?

Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
@nicolastakashi nicolastakashi force-pushed the docs/adding-analyze-operator-command branch from 145ff36 to 0fbe9cd Compare September 10, 2024 10:47
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@nicolastakashi nicolastakashi merged commit 6d4871e into main Sep 10, 2024
4 checks passed
nicolastakashi added a commit that referenced this pull request Sep 13, 2024
…perator-command

[DOCS] adding analyze operator cmd docs
@nicolastakashi nicolastakashi deleted the docs/adding-analyze-operator-command branch September 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants