Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hipchat_url is not consistent with api_url #875

Closed
brian-brazil opened this issue Jun 19, 2017 · 1 comment
Closed

hipchat_url is not consistent with api_url #875

brian-brazil opened this issue Jun 19, 2017 · 1 comment
Labels
component/config help wanted kind/cleanup low hanging fruit priority/Pmaybe

Comments

@brian-brazil
Copy link
Contributor

brian-brazil commented Jun 19, 2017 •
edited by stuartnelson3
Loading

The global default for the Hipchat url and its corresponding per-receiver setting are inconsistenly named. One has api, the other doesn't. This should be cleaned up.

Given that users shouldn't have to touch the global, I suggest renaming it to hipchat_api_url.
@josedonizetti josedonizetti mentioned this issue Nov 8, 2017
Merged
@josedonizetti
Copy link
Contributor

@stuartnelson3 This can be closed.

hh pushed a commit to ii/alertmanager that referenced this issue Sep 28, 2018
@daenney @grobie
filesystem: Ignore netns/nsfs mounts (prometheus#1047)
d999dac 
When starting Docker containers a whole bunch of netns (network
namespace) mounts are created that the node exporter can't make any
sense of (and can't read either).

This ignores all nsfs filesystems.

Fixes prometheus#875

Signed-off-by: Daniele Sluijters <daenney@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/config help wanted kind/cleanup low hanging fruit priority/Pmaybe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@josedonizetti @stuartnelson3 @mxinden @brian-brazil