amtool - Allow 'd', 'w', 'y' to be specified at time suffix when creating silence #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time.ParseDuration refused to parse them with the reason that a day can be shorter or longer than 24 hours. But they are already accepted in Prometheus range query and a custom parser is included in Prometheus common package so there's no reason amtool cannot use that. This will be handy in cases you need to create silence for longer periods, which are unfortunately common.
lebinh
changed the title
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Sep 30, 2018
Signed-off-by: Fabian Heymann <fabian.heymann@finanzcheck.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time.ParseDuration function refused to parse them with the reason is that a day
can be shorter or longer than 24 hours. But they are already accepted in
Prometheus range query and a custom parser is included in Prometheus
common package so there's no reason amtool cannot use that.
This will be handy in cases you need to create silence for longer periods,
which are unfortunately common.