Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't notify resolved alerts if none were firing #1198

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Don't notify resolved alerts if none were firing #1198

merged 2 commits into from
Jan 18, 2018

Conversation

simonpasquier
Copy link
Member

Closes #878

@simonpasquier
Copy link
Member Author

@stuartnelson3 PTAL

stuartnelson3
stuartnelson3 approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@stuartnelson3 stuartnelson3 merged commit 9b10aca into prometheus:master Jan 18, 2018
@simonpasquier simonpasquier deleted the fix-resolved-without-firing branch January 22, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonpasquier @stuartnelson3