Merged
Conversation
Member
Author
|
@stuartnelson3 do you think we should hold here due to #1643? I would be fine with a patch release once we can reproduce the issue. |
fc82aa8 to
67d9cb9
Compare
Closed
CHANGELOG.md
Outdated
| * [FEATURE] Introduce OpenAPI generated API v2 (#1352) | ||
| * [FEATURE] Lookup parts in strings using regexp.MatchString in templates (#1452) | ||
| * [FEATURE] Support image/thumb url in attachment in Slack notifier (#1506) | ||
| * [FEATURE] Support custom TLS certificates (#1528) |
Member
There was a problem hiding this comment.
Support custom TLS certificates for the email notifier (#1528)
CHANGELOG.md
Outdated
| * [ENHANCEMENT] Add name, value and SlackConfirmationField to action in Slack notifier (#1557) | ||
| * [ENHANCEMENT] Show more alert information on silence form and silence view pages (#1601) | ||
| * [ENHANCEMENT] Add cluster peers DNS refresh job (#1428) | ||
| * [ENHANCEMENT] [amtool] Support assuming first label is alertname in alert query with matchers (#1575) |
Contributor
There was a problem hiding this comment.
Yeah, this was the described behavior in the tool's help docs, I would say this was a bugfix
Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
67d9cb9 to
e30c73d
Compare
Member
Author
Thanks @simonpasquier. Fixed. |
stuartnelson3
approved these changes
Nov 30, 2018
Contributor
|
Looks good once it's green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the long list of changes I would like to start with an alpha release first. Hence this replaces #1553.
Signed-off-by: Max Leonard Inden IndenML@gmail.com