Add negative matchers for routing. #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
asquare14
changed the title
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
asquare14
changed the title
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
asquare14
force-pushed
the
patch-1023
branch
from
51e15df
to
4886074
Compare
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
beorn7
requested changes
Dec 22, 2020
There was a problem hiding this comment.
Big picture: In principle, things should work as you have done here, but I think we should go one step further and fully embrace the labels.Matcher for matchers in the config (but not (yet) for matchers in silences, see comments for details). We can talk 1:1 about it if you have questions. (I have found a few issues with the labels.Matcher while looking at the code, which we can also discuss in person.)
"Operational" note: In this PR, you effectively ignore a parsing error twice. It's a good general rule for Go code to only ignore errors if you know exactly why, and then add a comment explaining why it is fine to ignore the error. (Spoiler: In these two cases, it's not fine…)
The alert was just looking at the minimum across integrations. So a complete failure of one integration would be masked by a still worknig other integration. With this fix, the `integration` label is retained (as it was already expected by the `description`), and thus any failing integration will trigger the alert. In addition, an `alertmanagerCriticalIntegrationsRegEx` is provided that allows to mark integrations as critical. Integrations that are not used to deliver critical alerts, or those that are just there for auditing and logging purposes can now be configured to only trigger a warning alert if they fail. Signed-off-by: beorn7 <beorn@grafana.com>
The doc comments do not describe the current (arguably buggy) state, but the desired state, as it will be implemented in future commits. Signed-off-by: beorn7 <beorn@grafana.com>
This addresses a number of issues: - It was impossible to include a literal '"' or a line break in the value. - It was impossible to include '=', '~', or '!' in the value. - It was not validated if the label name is valid. - It was not validated if the value is valid UTF-8. - No whitespace was allowed around the operator. Signed-off-by: beorn7 <beorn@grafana.com>
Previously, escaped double quotes would still be seen as ending the quoting, potentially leading to wronk tokenization. Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
beorn7
requested changes
Jan 12, 2021
beorn7
requested changes
Jan 12, 2021
beorn7
reviewed
Jan 12, 2021
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
beorn7
requested changes
Jan 13, 2021
Now the string created will correctly parse back. Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
vladimiroff
reviewed
Jan 13, 2021
|
Cool. Besides that minor issue about sorting by @simonpasquier could you give this a final look? Note that ideally, this gets merged together with #2441, where I'd appreciate your review, too. |
Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
beorn7
reviewed
Jan 14, 2021
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
Improve labels.Matcher
beorn7
approved these changes
Jan 15, 2021
|
In the same spirit as #2441, I'll merge this now. |
Signed-off-by: beorn7 <beorn@grafana.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: aSquare14 atibhi.a@gmail.com
Related issue : #1023
Note : I am adding negative matchers for routing in this PR. Will add support for inhibition rules in next PR.