Fix resolved header in email template

[nileger]

Background

We use a custom email template based on alertmanager/template/email.tmpl.

Problem

The email template for resolved messages currently has a styling issue. Due to an extra </td>, the green heading is only shown in the top right corner, instead of covering the full width.

Solution

Removing the extra </td> solves the issue.

[nileger]

Can anyone help with the DCO check, please?

[simonpasquier]

template/email.tmpl gets generated from template/email.html via the template/inline-css.js script which uses juice under the hood to inline the CSS properies into the style attributes.

IIUC juice is confused by this part and adds the extra </td>

alertmanager/template/email.html

Lines 326 to 334 in dcc92ed

	{{ if gt (len .Alerts.Firing) 0 }}
	<td class="alert alert-warning">
	{{ else }}
	<td class="alert alert-good">
	{{ end }}
	{{ .Alerts | len }} alert{{ if gt (len .Alerts) 1 }}s{{ end }} for {{ range .GroupLabels.SortedPairs }}
	{{ .Name }}={{ .Value }}
	{{ end }}
	</td>

One way to fix it would be to duplicate the range loop like this:

 {{ if gt (len .Alerts.Firing) 0 }} 
 <td class="alert alert-warning"> 
   {{ .Alerts | len }} alert{{ if gt (len .Alerts) 1 }}s{{ end }} for {{ range .GroupLabels.SortedPairs }} 
     {{ .Name }}={{ .Value }}  
   {{ end }} 
 </td>
 {{ else }} 
 <td class="alert alert-good"> 
   {{ .Alerts | len }} alert{{ if gt (len .Alerts) 1 }}s{{ end }} for {{ range .GroupLabels.SortedPairs }} 
     {{ .Name }}={{ .Value }}  
   {{ end }} 
 </td>
 {{ end }} 

[cod-r]

Can this be merged? We are having the same problem and is annoying.

[simonpasquier]

@cod-r this should be fixed in the latest v0.25.0 thanks to #3166