Implement Stringer interface for Pairs and KVs #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the Stringer interface for Pairs and KVs. It changes how Pairs are printed in templates from map[name1:value1 name2:value2] to name1=value1, name2=value2. KVs work similar, but are first sorted into pairs before being printed. Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
stringer-for-pairs-and-kvs
branch
from
5489eb7 to
81d78f3
Compare
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
This commit implements the Stringer interface for Pairs and KVs. It changes how Pairs are printed in templates from map[name1:value1 name2:value2] to name1=value1, name2=value2. KVs work similar, but are first sorted into pairs before being printed. Signed-off-by: George Robinson <george.robinson@grafana.com>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
This commit implements the Stringer interface for Pairs and KVs. It changes how Pairs are printed in templates from map[name1:value1 name2:value2] to name1=value1, name2=value2. KVs work similar, but are first sorted into pairs before being printed. Signed-off-by: George Robinson <george.robinson@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the
Stringerinterface for Pairs and KVs. It changes how Pairs are printed in templates frommap[name1:value1 name2:value2]toname1=value1, name2=value2. KVs work similar, but are first sorted into pairs before being printed.This should mean that Alertmanager has better text when using
{{ .Annotations }}and{{ .Labels }}, as an example, without having to write arangewith custom delimitation.