Enable setting ThreadId for Telegram notifications #3638

th0th · 2023-12-15T11:21:01Z

Enable setting message_thread_id for Telegram notifications.

yuri-tceretian · 2023-12-15T14:18:56Z

Please add

tests here and here
documentation here

Also, please update the description of this PR with more information. Link to another PR is not a really good description. Thanks!

th0th · 2023-12-15T15:45:44Z

Please add

tests here and here

documentation here

Also, please update the description of this PR with more information. Link to another PR is not a really good description. Thanks!

Done 👍

The tests looked OK to me, but let me know if you think you need more cases.

jsDotx3 · 2023-12-29T15:04:51Z

Any updates?

yuri-tceretian · 2024-01-02T15:59:52Z

@gotjosh @simonpasquier can you please review the PR?

yuri-tceretian · 2024-01-02T17:26:43Z

config/notifiers.go

@@ -753,6 +753,7 @@ type TelegramConfig struct {
 	BotToken             Secret `yaml:"bot_token,omitempty" json:"token,omitempty"`
 	BotTokenFile         string `yaml:"bot_token_file,omitempty" json:"token_file,omitempty"`
 	ChatID               int64  `yaml:"chat_id,omitempty" json:"chat,omitempty"`
+	MessageThreadID      int64  `yaml:"message_thread_id,omitempty" json:"message_thread_id,omitempty"`


according to the documentation the field is Integer, which is a 32-bit signed integer. Perhaps let's change it to int32?

according to the documentation the field is Integer, which is a 32-bit signed integer. Perhaps let's change it to int32?

Telegram doesn't use 32 bit integer anymore since API Layer 133, Integer in Telegram documentation can be safely assumed as 64-bit integer

Then it looks like there is a discrepancy in the documentation. I refer to Bot API where https://core.telegram.org/bots/api#available-types that says:

It is safe to use 32-bit signed integers for storing all Integer fields unless otherwise noted.

I updated MessageThreadID as int32, and also updated my branch with the upstream one.

asonnleitner · 2024-01-31T19:45:10Z

@yuri-tceretian This is a duplicate of an existing pull request, #3560, which has been pending review since October 16, 2023, nearing four months. Several maintainers have been tagged for attention. It is disappointing to see this duplicate receiving more attention.

raphielscape · 2024-01-31T20:21:18Z

@yuri-tceretian This is a duplicate of an existing pull request, #3638, which has been pending review since October 16, 2023, nearing four months. Several maintainers have been tagged for attention. It is disappointing to see this duplicate receiving more attention.

If you mean #3560, this is not duplicate, message_thread_id inclusion is different compared to reply_to_message_id, even though the idea is the same (sending message to a certain topic), message_thread is the intended way to sending a message to a certain topic, reply_to_message, as the fields name says, are more targeted to replying to a certain message ID rather than sending messages.

asonnleitner · 2024-01-31T20:28:29Z

@yuri-tceretian This is a duplicate of an existing pull request, #3638, which has been pending review since October 16, 2023, nearing four months. Several maintainers have been tagged for attention. It is disappointing to see this duplicate receiving more attention.

If you mean #3560, this is not duplicate, message_thread_id inclusion is different compared to reply_to_message_id, even though the idea is the same (sending message to a certain topic), message_thread is the intended way to sending a message to a certain topic, reply_to_message, as the fields name says, are more targeted to replying to a certain message ID rather than sending messages.

Thank you, @raphielscape, for explaining the differences between PR #3560 and the current request. Your insight into how message_thread_id differs from reply_to_message_id is very helpful. Considering both PRs are focused on enhancing Telegram-related functionalities, it might be beneficial if the maintainers could review and possibly merge them both 🚀

cahyahikmawan · 2024-02-20T03:35:58Z

hi guys, just a quick question.
any plan for merging this PR and releasing the new feature?

TheMeier · 2024-03-20T05:44:11Z

Please rebase and sign. See https://github.com/prometheus/alertmanager/pull/3638/checks?check_run_id=21162278935

th0th · 2024-03-23T18:57:33Z

Please rebase and sign. See https://github.com/prometheus/alertmanager/pull/3638/checks?check_run_id=21162278935

I followed the instructions on the link you shared, please let me know if there is anything else I need to do 💐

grobinson-grafana · 2024-03-23T19:40:30Z

@th0th I don't think you rebased correctly as there are now 73 commits in this PR. Did you use git rebase? You also still need to sign off all of your commits with --signoff.

th0th · 2024-03-23T19:47:49Z

@th0th I don't think you rebased correctly as there are now 73 commits in this PR. Did you use git rebase? You also still need to sign off all of your commits with --signoff.

I followed the exact instructions on the link, but I think the commit history got messed up since I previously merged the upstream branch to my own branch. And now I don't know how to fix 😅

grobinson-grafana · 2024-03-23T20:01:36Z

You can squash all the commits into a single commit using git rebase and then sign the commit using git commit --amend --no-edit --signoff.

Another option is to delete the branch, create a new branch with the same name, add the modifications, commit them, and then force push the branch to GitHub and it will replace the old branch.

grobinson-grafana · 2024-03-25T10:21:28Z

notify/telegram/telegram.go

@@ -93,6 +93,7 @@ func (n *Notifier) Notify(ctx context.Context, alert ...*types.Alert) (bool, err
 	message, err := n.client.Send(telebot.ChatID(n.conf.ChatID), messageText, &telebot.SendOptions{
 		DisableNotification:   n.conf.DisableNotifications,
 		DisableWebPagePreview: true,
+		ThreadID:              int(n.conf.MessageTheadID),


This doesn't compile I'm afraid:

notify/telegram/telegram.go:96:37: n.conf.MessageTheadID undefined (type *"github.com/prometheus/alertmanager/config".TelegramConfig has no field or method MessageTheadID)

th0th · 2024-03-25T17:05:37Z

You can squash all the commits into a single commit using git rebase and then sign the commit using git commit --amend --no-edit --signoff.

Another option is to delete the branch, create a new branch with the same name, add the modifications, commit them, and then force push the branch to GitHub and it will replace the old branch.

I rebased, and it reduced the number of commits but there are still some commits that are shown in this PR, but not mine. No idea why.

The compile fail was due to a typo I guess, I fixed that, too.

grobinson-grafana · 2024-03-25T19:08:43Z

I rebased, and it reduced the number of commits but there are still some commits that are shown in this PR, but not mine. No idea why.

Can you share the commands you ran to rebase?

grobinson-grafana · 2024-03-25T19:10:40Z

ui/react-app/package-lock.json

@@ -56,6 +56,15 @@
        "node": ">=0.10.0"
      }
    },
+    "node_modules/@aashutoshrathi/word-wrap": {


I'm not sure where this has come from?

grobinson-grafana · 2024-03-25T19:13:30Z

Can you also run go mod tidy as otherwise it doesn't seem to compile:

../../../../../../pkg/mod/github.com/go-openapi/spec@v0.20.9/header.go:21:2: missing go.sum entry for module providing package github.com/go-openapi/jsonpointer (imported by github.com/go-openapi/analysis); to add:
	go get github.com/go-openapi/analysis@v0.21.4
../../../../../../pkg/mod/github.com/go-openapi/spec@v0.20.9/ref.go:25:2: missing go.sum entry for module providing package github.com/go-openapi/jsonreference (imported by github.com/go-openapi/spec); to add:
	go get github.com/go-openapi/spec@v0.20.9

th0th · 2024-03-25T21:33:28Z

I rebased, and it reduced the number of commits but there are still some commits that are shown in this PR, but not mine. No idea why.

Can you share the commands you ran to rebase?

I did this:

git remote add upstream https://github.com/prometheus/alertmanager.git
git rebase upstream/main

grobinson-grafana · 2024-03-26T10:41:06Z

I rebased, and it reduced the number of commits but there are still some commits that are shown in this PR, but not mine. No idea why.

Can you share the commands you ran to rebase?

I did this:
git remote add upstream https://github.com/prometheus/alertmanager.git
git rebase upstream/main

Did you merge main before the rebase? If so, that might have caused the issue. I would just squash all 16 commits in this branch to a single commit using git rebase and then we can go from there. There is a nice tutorial on how to do that here.

hatamiarash7 · 2024-04-08T13:42:50Z

come on :))) merge this

grobinson-grafana · 2024-04-16T14:41:39Z

Hi @th0th! 👋 Do you need help with the rebase?

th0th · 2024-04-16T22:45:33Z

Hi @th0th! 👋 Do you need help with the rebase?

I do indeed 🙃

th0th · 2024-04-17T11:17:36Z

OK. I ran the following:

git fetch
git rebase origin/main // here origin is git@github.com:prometheus/alertmanager.git
git rebase -i HEAD~16

I then did the following:

pick 9f7f92cd Enable setting ThreadId for telegram notifications
s 7dceb6fa Fix the typo
s 0274e497 Update tests
s 5ec55ae7 Update documentation
s 15682c4a Update notifiers_test.go
s a75dd888 Update notifiers_test.go
s b6017dd0 Use int32 instead of int64 for MessageThreadID
s 3cecaae6 Bump github.com/go-openapi/swag from 0.22.4 to 0.22.7 (#3655)
d b29d9af6 Support UTF-8 label matchers: Add metrics to matchers compat package (#3658)
d c8eca8d9 Change compat metrics to counters (#3686)
s 3c958067 Bump github.com/go-openapi/errors from 0.20.4 to 0.21.0
s aeb3cdbd Bump github.com/go-openapi/swag from 0.22.7 to 0.22.9
s 37426b93 Bump eslint from 8.35.0 to 8.56.0 in /ui/react-app (#3692)
d 084e0d0c Do not register compat metrics in amtool (#3713)
d 70540688 Remove metrics from compat package (#3714)
s ef146bce Fix the typo

This removes the unrelated commits and squashes the others into a single commit. I also removed the commit messages of all other commits except the first commit. You can see here that this leaves just one commit ahead of main:

git log master..th0th/main --oneline
fa78ab4b (HEAD -> th0th/main) Enable setting ThreadId for telegram notifications
cb9724db (origin/main, origin/HEAD, main) notify/webhook: Fix crash on errors when url_file is used (#3798) (#3800)

Thanks a lot @grobinson-grafana. But when I run git rebase -i HEAD~16, and put in the input, it says:

➜  alertmanager git:(main) git rebase -i HEAD~16

error: could not parse '9f7f92cd'
error: invalid line 1: pick 9f7f92cd Enable setting ThreadId for telegram notifications
error: could not parse '7dceb6fa'
error: invalid line 2: s 7dceb6fa Fix the typo
error: could not parse '0274e497'
error: invalid line 3: s 0274e497 Update tests
error: could not parse '5ec55ae7'
error: invalid line 4: s 5ec55ae7 Update documentation
error: could not parse '15682c4a'
error: invalid line 5: s 15682c4a Update notifiers_test.go
error: could not parse 'a75dd888'
error: invalid line 6: s a75dd888 Update notifiers_test.go
error: could not parse 'b6017dd0'
error: invalid line 7: s b6017dd0 Use int32 instead of int64 for MessageThreadID
error: could not parse '3cecaae6'
error: invalid line 8: s 3cecaae6 Bump github.com/go-openapi/swag from 0.22.4 to 0.22.7 (#3655)
error: could not parse 'b29d9af6'
error: invalid line 9: d b29d9af6 Support UTF-8 label matchers: Add metrics to matchers compat package (#3658)
error: could not parse 'c8eca8d9'
error: invalid line 10: d c8eca8d9 Change compat metrics to counters (#3686)
error: could not parse '3c958067'
error: invalid line 11: s 3c958067 Bump github.com/go-openapi/errors from 0.20.4 to 0.21.0
error: could not parse 'aeb3cdbd'
error: invalid line 12: s aeb3cdbd Bump github.com/go-openapi/swag from 0.22.7 to 0.22.9
error: could not parse '37426b93'
error: invalid line 13: s 37426b93 Bump eslint from 8.35.0 to 8.56.0 in /ui/react-app (#3692)
error: could not parse '084e0d0c'
error: invalid line 14: d 084e0d0c Do not register compat metrics in amtool (#3713)
error: could not parse '70540688'
error: invalid line 15: d 70540688 Remove metrics from compat package (#3714)
error: could not parse 'ef146bce'
error: invalid line 16: s ef146bce Fix the typo
You can fix this with 'git rebase --edit-todo' and then run 'git rebase --continue'.
Or you can abort the rebase with 'git rebase --abort'.

What am I doing wrong? :(

grobinson-grafana · 2024-04-17T14:19:38Z

What am I doing wrong? :(

You should be able to edit what is there when you run git rebase -i HEAD~16 – you don't need to copy/paste what I wrote. Basically you should change all pick to s (for squash) with the following exceptions:

9f7f92cd should be kept as pick because this is the first commit
b29d9af6 should be d (for drop)
c8eca8d9 should be d (for drop)
084e0d0c should be d (for drop)
70540688 should be d (for drop)

Fix the typo Signed-off-by: Gokhan Sari <gokhan@sari.me> Update tests Signed-off-by: Gokhan Sari <gokhan@sari.me> Update documentation Signed-off-by: Gokhan Sari <gokhan@sari.me> Update notifiers_test.go Signed-off-by: Gokhan Sari <gokhan@sari.me> Update notifiers_test.go Signed-off-by: Gokhan Sari <gokhan@sari.me> Use int32 instead of int64 for MessageThreadID Signed-off-by: Gokhan Sari <gokhan@sari.me> Bump github.com/go-openapi/swag from 0.22.4 to 0.22.7 (prometheus#3655) Bumps [github.com/go-openapi/swag](https://github.com/go-openapi/swag) from 0.22.4 to 0.22.7. - [Commits](go-openapi/swag@v0.22.4...v0.22.7) --- updated-dependencies: - dependency-name: github.com/go-openapi/swag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Support UTF-8 label matchers: Add metrics to matchers compat package (prometheus#3658) * Add metrics to matchers compat package This commit adds the following metrics to the compat package: alertmanager_matchers_parse alertmanager_matchers_disagree alertmanager_matchers_incompatible alertmanager_matchers_invalid With a label called origin to differentiate the different sources of inputs: the configuration file, the API, and amtool. The disagree_total metric is incremented when an input is invalid in both parsers, but results in different parsed representations, then there is disagreement. This should not happen, and suggests their is either a bug in one of the parsers or a mistake in the backwards compatible guarantees of the matchers/parse parser. The incompatible_total metric is incremented when an input is valid in pkg/labels, but not the UTF-8 parser in matchers/parse. In such case, the matcher should be updated to be compatible. This often means adding double quotes around the right hand side of the matcher. For example, foo="bar". The invalid_total metric is incremented when an input is invalid in both parsers. This was never a valid input. The tests have been updated to check the metrics are incremented as expected. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Change compat metrics to counters (prometheus#3686) This commit changes the metrics in the compat package from gauges to counters. The reason for this is that in some cases the gauge should behave like a gauge (i.e. loading configurations) but in other cases should behave like a counter (i.e. HTTP requests). Second, because the compat package is a global package (due to how config.Load works), in tenanted systems like Cortex and Mimir it was non-trivial to reset the gauges per tenant each time their configuration was reloaded. Instead, it's easier to compute the rate of increase as 0 instead of check that the gauge is 0 to know if UTF-8 strict mode can be enabled. Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Bump github.com/go-openapi/errors from 0.20.4 to 0.21.0 Bumps [github.com/go-openapi/errors](https://github.com/go-openapi/errors) from 0.20.4 to 0.21.0. - [Commits](go-openapi/errors@v0.20.4...v0.21.0) --- updated-dependencies: - dependency-name: github.com/go-openapi/errors dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Bump github.com/go-openapi/swag from 0.22.7 to 0.22.9 Bumps [github.com/go-openapi/swag](https://github.com/go-openapi/swag) from 0.22.7 to 0.22.9. - [Commits](go-openapi/swag@v0.22.7...v0.22.9) --- updated-dependencies: - dependency-name: github.com/go-openapi/swag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Bump eslint from 8.35.0 to 8.56.0 in /ui/react-app (prometheus#3692) Bumps [eslint](https://github.com/eslint/eslint) from 8.35.0 to 8.56.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.35.0...v8.56.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Do not register compat metrics in amtool (prometheus#3713) There is no need to register these metrics in amtool, so use compat.NewMetrics(nil) instead of compat.RegisteredMetrics. Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Remove metrics from compat package (prometheus#3714) This commit removes the metrics from the compat package in favour of the existing logging and the additional tools at hand, such as amtool, to validate Alertmanager configurations. Due to the global nature of the compat package, a consequence of config.Load, these metrics have proven to be less useful in practice than expected, both in Alertmanager and other projects such as Mimir. There are a number of reasons for this: 1. Because the compat package is global, these metrics cannot be reset each time config.Load is called, as in multi-tenant projects like Mimir loading a config for one tenant would reset the metrics for all tenants. This is also the reason the metrics are counters and not gauges. 2. Since the metrics are counters, it is difficult to create meaningful dashboards for Alertmanager as, unlike in Mimir, configurations are not reloaded at fixed intervals, and as such, operators cannot use rate to track configuration changes over time. In Alertmanager, there are much better tools available to validate that an Alertmanager configuration is compatible with the UTF-8 parser, including both the existing logging from Alertmanager server and amtool check-config. In other projects like Mimir, we can track configurations for individual tenants using log aggregation and storage systems such as Loki. This gives operators far more information than what is possible with the metrics, including the timestamp, input and ID of tenant configurations that are incompatible or have disagreement. Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Gokhan Sari <gokhan@sari.me> Fix the typo Revert changes in unintended files

th0th · 2024-04-18T00:06:30Z

What am I doing wrong? :(

You should be able to edit what is there when you run git rebase -i HEAD~16 – you don't need to copy/paste what I wrote. Basically you should change all pick to s (for squash) with the following exceptions:

9f7f92cd should be kept as pick because this is the first commit

b29d9af6 should be d (for drop)

c8eca8d9 should be d (for drop)

084e0d0c should be d (for drop)

70540688 should be d (for drop)

I think I managed to rebase, can you please confirm @grobinson-grafana? 💐

grobinson-grafana · 2024-04-23T19:35:25Z

I think I managed to rebase, can you please confirm @grobinson-grafana? 💐

Looks good to me! @gotjosh can you help with CircleCI?

grobinson-grafana · 2024-04-30T09:37:51Z

Thanks Josh! @th0th there are some failing tests (please see CI / Test https://github.com/prometheus/alertmanager/actions/runs/8892559543/job/24416875284?pr=3638). You can also run make test before committing the fix to make sure there are no other failing tests.

Signed-off-by: gotjosh <josue.abreu@gmail.com>

gotjosh

LGTM

gotjosh · 2024-04-30T10:13:08Z

Thank you very much for your contribution!

grobinson-grafana · 2024-04-30T11:44:19Z

@th0th Thanks also for the contribution! I would appreciate it if you could test it and make sure it works as I cannot seem to create a Telegram supergroup or topics (perhaps I just don't know how to do it?).

th0th · 2024-04-30T13:21:12Z

Thanks for the help getting this merged folks :) @grobinson-grafana I would love to test, but I am using grafana right now, and I don't have alertmanager running separately :(

grobinson-grafana · 2024-04-30T15:37:03Z

Thanks for the help getting this merged folks :) @grobinson-grafana I would love to test, but I am using grafana right now, and I don't have alertmanager running separately :(

How would I go about starting a thread in Telegram? I've tried creating both a channel and a group and I can't seem to get it to work. With the channel, all replies use reply_to_message_id instead of message_thread_id. With the group, it seems I cannot create topics because I need to have 200 members, and here also all replies use reply_to_message_id instead of message_thread_id.

grobinson-grafana · 2024-04-30T16:05:40Z

OK, I managed to create a supergroup and then create topics.

receivers:
  - name: telegram
    telegram_configs:
      - bot_token: xxx
        chat_id: -1002096584164
        message_thread_id: 15
route:
  receiver: telegram
  group_wait: 15s
  group_interval: 30s

ts=2024-04-30T15:59:38.854Z caller=dispatch.go:164 level=debug component=dispatcher msg="Received alert" alert=[3fff2c2][active]
ts=2024-04-30T15:59:53.855Z caller=dispatch.go:516 level=debug component=dispatcher aggrGroup={}:{} msg=flushing alerts=[[3fff2c2][active]]
ts=2024-04-30T15:59:54.064Z caller=telegram.go:101 level=debug integration=telegram msg="Telegram message successfully published" message_id=18 chat_id=-1002096584164
ts=2024-04-30T15:59:54.064Z caller=notify.go:863 level=debug component=dispatcher receiver=telegram integration=telegram[0] aggrGroup={}:{} alerts=[[3fff2c2][active]] msg="Notify success" attempts=1 duration=208.804917ms
...
ts=2024-04-30T16:04:53.853Z caller=dispatch.go:516 level=debug component=dispatcher aggrGroup={}:{} msg=flushing alerts=[[3fff2c2][resolved]]
ts=2024-04-30T16:04:53.941Z caller=telegram.go:101 level=debug integration=telegram msg="Telegram message successfully published" message_id=20 chat_id=-1002096584164
ts=2024-04-30T16:04:53.942Z caller=notify.go:863 level=debug component=dispatcher receiver=telegram integration=telegram[0] aggrGroup={}:{} alerts=[[3fff2c2][resolved]] msg="Notify success" attempts=1 duration=88.678291ms

* Enable setting ThreadId for telegram notifications Signed-off-by: Gokhan Sari <gokhan@sari.m --------- Signed-off-by: gotjosh <josue.abreu@gmail.com>

dabelousov · 2024-08-09T07:25:16Z

Hi! When are you going to make a new release with that MR?

hatamiarash7 · 2024-08-10T12:21:00Z

Hi! When are you going to make a new release with that MR?

#3243 (comment)

* Enable setting ThreadId for telegram notifications Signed-off-by: Gokhan Sari <gokhan@sari.m --------- Signed-off-by: gotjosh <josue.abreu@gmail.com>

* [CHANGE] Deprecate and remove api/v1/ #2970 * [CHANGE] Remove unused feature flags #3676 * [CHANGE] Newlines in smtp password file are now ignored #3681 * [CHANGE] Change compat metrics to counters #3686 * [CHANGE] Do not register compat metrics in amtool #3713 * [CHANGE] Remove metrics from compat package #3714 * [CHANGE] Mark muted alerts #3793 * [FEATURE] Add metric for inhibit rules #3681 * [FEATURE] Support UTF-8 label matchers #3453, #3507, #3523, #3483, #3567, #3568, #3569, #3571, #3595, #3604, #3619, #3658, #3659, #3662, #3668, 3572 * [FEATURE] Add counter to track alerts dropped outside of time_intervals #3565 * [FEATURE] Add date and tz functions to templates #3812 * [FEATURE] Add limits for silences #3852 * [FEATURE] Add time helpers for templates #3863 * [FEATURE] Add auto GOMAXPROCS #3837 * [FEATURE] Add auto GOMEMLIMIT #3895 * [FEATURE] Add Jira receiver integration #3590 * [ENHANCEMENT] Add the receiver name to notification metrics #3045 * [ENHANCEMENT] Add the route ID to uuid #3372 * [ENHANCEMENT] Add duration to the notify success message #3559 * [ENHANCEMENT] Implement webhook_url_file for discord and msteams #3555 * [ENHANCEMENT] Add debug logs for muted alerts #3558 * [ENHANCEMENT] API: Allow the Silences API to use their own 400 response #3610 * [ENHANCEMENT] Add summary to msteams notification #3616 * [ENHANCEMENT] Add context reasons to notifications failed counter #3631 * [ENHANCEMENT] Add optional native histogram support to latency metrics #3737 * [ENHANCEMENT] Enable setting ThreadId for Telegram notifications #3638 * [ENHANCEMENT] Allow webex roomID from template #3801 * [BUGFIX] Add missing integrations to notify metrics #3480 * [BUGFIX] Add missing ttl in pushhover #3474 * [BUGFIX] Fix scheme required for webhook url in amtool #3409 * [BUGFIX] Remove duplicate integration from metrics #3516 * [BUGFIX] Reflect Discord's max length message limits #3597 * [BUGFIX] Fix nil error in warn logs about incompatible matchers #3683 * [BUGFIX] Fix a small number of inconsistencies in compat package logging #3718 * [BUGFIX] Fix log line in featurecontrol #3719 * [BUGFIX] Fix panic in acceptance tests #3592 * [BUGFIX] Fix flaky test TestClusterJoinAndReconnect/TestTLSConnection #3722 * [BUGFIX] Fix crash on errors when url_file is used #3800 * [BUGFIX] Fix race condition in dispatch.go #3826 * [BUGFIX] Fix race conditions in the memory alerts store #3648 * [BUGFIX] Hide config.SecretURL when the URL is incorrect. #3887 * [BUGFIX] Fix invalid silence causes incomplete updates #3898 * [BUGFIX] Fix leaking of Silences matcherCache entries #3930 * [BUGFIX] Close SMTP submission correctly to handle errors #4006 Signed-off-by: SuperQ <superq@gmail.com>

* Release v0.28.0-rc.0 * [CHANGE] Templating errors in the SNS integration now return an error. #3531 #3879 * [FEATURE] Add a new Microsoft Teams integration based on Flows #4024 * [FEATURE] Add a new Rocket.Chat integration #3600 * [FEATURE] Add a new Jira integration #3590 #3931 * [FEATURE] Add support for `GOMEMLIMIT`, enable it via the feature flag `--enable-feature=auto-gomemlimit`. #3895 * [FEATURE] Add support for `GOMAXPROCS`, enable it via the feature flag `--enable-feature=auto-gomaxprocs`. #3837 * [FEATURE] Add support for limits of silences including the maximum number of active and pending silences, and the maximum size per silence (in bytes). You can use the flags `--silences.max-silences` and `--silences.max-silence-size-bytes` to set them accordingly #3852 #3862 #3866 #3885 #3886 #3877 * [FEATURE] Muted alerts now show whether they are suppressed or not in both the `/api/v2/alerts` endpoint and the Alertmanager UI. #3793 #3797 #3792 * [ENHANCEMENT] Add support for `content`, `username` and `avatar_url` in the Discord integration. `content` and `username` also support templating. #4007 * [ENHANCEMENT] Only invalidate the silences cache if a new silence is created or an existing silence replaced - should improve latency on both `GET api/v2/alerts` and `POST api/v2/alerts` API endpoint. #3961 * [ENHANCEMENT] Add image source label to Dockerfile. To get changelogs shown when using Renovate #4062 * [ENHANCEMENT] Build using go 1.23 #4071 * [ENHANCEMENT] Support setting a global SMTP TLS configuration. #3732 * [ENHANCEMENT] The setting `room_id` in the WebEx integration can now be templated to allow for dynamic room IDs. #3801 * [ENHANCEMENT] Enable setting `message_thread_id` for the Telegram integration. #3638 * [ENHANCEMENT] Support the `since` and `humanizeDuration` functions to templates. This means users can now format time to more human-readable text. #3863 * [ENHANCEMENT] Support the `date` and `tz` functions to templates. This means users can now format time in a specified format and also change the timezone to their specific locale. #3812 * [ENHANCEMENT] Latency metrics now support native histograms. #3737 * [BUGFIX] Fix the SMTP integration not correctly closing an SMTP submission, which may lead to unsuccessful dispatches being marked as successful. #4006 * [BUGFIX] The `ParseMode` option is now set explicitly in the Telegram integration. If we don't HTML tags had not been parsed by default. #4027 * [BUGFIX] Fix a memory leak that was caused by updates silences continuously. #3930 * [BUGFIX] Fix hiding secret URLs when the URL is incorrect. #3887 * [BUGFIX] Fix a race condition in the alerts - it was more of a hypothetical race condition that could have occurred in the alert reception pipeline. #3648 * [BUGFIX] Fix a race condition in the alert delivery pipeline that would cause a firing alert that was delivered earlier to be deleted from the aggregation group when instead it should have been delivered again. #3826 * [BUGFIX] Fix version in APIv1 deprecation notice. #3815 * [BUGFIX] Fix crash errors when using `url_file` in the Webhook integration. #3800 * [BUGFIX] fix `Route.ID()` returns conflicting IDs. #3803 * [BUGFIX] Fix deadlock on the alerts memory store. #3715 * [BUGFIX] Fix `amtool template render` when using the default values. #3725 * [BUGFIX] Fix `webhook_url_file` for both the Discord and Microsoft Teams integrations. #3728 #3745 --------- Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>

* [CHANGE] Templating errors in the SNS integration now return an error. #3531 #3879 * [CHANGE] Adopt log/slog, drop go-kit/log #4089 * [FEATURE] Add a new Microsoft Teams integration based on Flows #4024 * [FEATURE] Add a new Rocket.Chat integration #3600 * [FEATURE] Add a new Jira integration #3590 #3931 * [FEATURE] Add support for `GOMEMLIMIT`, enable it via the feature flag `--enable-feature=auto-gomemlimit`. #3895 * [FEATURE] Add support for `GOMAXPROCS`, enable it via the feature flag `--enable-feature=auto-gomaxprocs`. #3837 * [FEATURE] Add support for limits of silences including the maximum number of active and pending silences, and the maximum size per silence (in bytes). You can use the flags `--silences.max-silences` and `--silences.max-silence-size-bytes` to set them accordingly #3852 #3862 #3866 #3885 #3886 #3877 * [FEATURE] Muted alerts now show whether they are suppressed or not in both the `/api/v2/alerts` endpoint and the Alertmanager UI. #3793 #3797 #3792 * [ENHANCEMENT] Add support for `content`, `username` and `avatar_url` in the Discord integration. `content` and `username` also support templating. #4007 * [ENHANCEMENT] Only invalidate the silences cache if a new silence is created or an existing silence replaced - should improve latency on both `GET api/v2/alerts` and `POST api/v2/alerts` API endpoint. #3961 * [ENHANCEMENT] Add image source label to Dockerfile. To get changelogs shown when using Renovate #4062 * [ENHANCEMENT] Build using go 1.23 #4071 * [ENHANCEMENT] Support setting a global SMTP TLS configuration. #3732 * [ENHANCEMENT] The setting `room_id` in the WebEx integration can now be templated to allow for dynamic room IDs. #3801 * [ENHANCEMENT] Enable setting `message_thread_id` for the Telegram integration. #3638 * [ENHANCEMENT] Support the `since` and `humanizeDuration` functions to templates. This means users can now format time to more human-readable text. #3863 * [ENHANCEMENT] Support the `date` and `tz` functions to templates. This means users can now format time in a specified format and also change the timezone to their specific locale. #3812 * [ENHANCEMENT] Latency metrics now support native histograms. #3737 * [ENHANCEMENT] Add timeout option for webhook notifier. #4137 * [BUGFIX] Fix the SMTP integration not correctly closing an SMTP submission, which may lead to unsuccessful dispatches being marked as successful. #4006 * [BUGFIX] The `ParseMode` option is now set explicitly in the Telegram integration. If we don't HTML tags had not been parsed by default. #4027 * [BUGFIX] Fix a memory leak that was caused by updates silences continuously. #3930 * [BUGFIX] Fix hiding secret URLs when the URL is incorrect. #3887 * [BUGFIX] Fix a race condition in the alerts - it was more of a hypothetical race condition that could have occurred in the alert reception pipeline. #3648 * [BUGFIX] Fix a race condition in the alert delivery pipeline that would cause a firing alert that was delivered earlier to be deleted from the aggregation group when instead it should have been delivered again. #3826 * [BUGFIX] Fix version in APIv1 deprecation notice. #3815 * [BUGFIX] Fix crash errors when using `url_file` in the Webhook integration. #3800 * [BUGFIX] fix `Route.ID()` returns conflicting IDs. #3803 * [BUGFIX] Fix deadlock on the alerts memory store. #3715 * [BUGFIX] Fix `amtool template render` when using the default values. #3725 * [BUGFIX] Fix `webhook_url_file` for both the Discord and Microsoft Teams integrations. #3728 #3745 * [BUGFIX] Fix wechat api link #4084 * [BUGFIX] Fix build info metric #4166 Signed-off-by: SuperQ <superq@gmail.com>

This was referenced Dec 15, 2023

Add message_thread_id for Telegram contact points grafana/terraform-provider-grafana#1234

Merged

Alerting: Enable sending notifications to a specific topic on Telegram grafana/grafana#79546

Merged

yuri-tceretian reviewed Jan 2, 2024

View reviewed changes

TheMeier mentioned this pull request Mar 20, 2024

add support customize telegram #3769

Open

grobinson-grafana mentioned this pull request Mar 23, 2024

Supported reply_to_message_id for Telegram topics. #3560

Open

th0th force-pushed the main branch from a7b1ed4 to 00aea3e Compare March 23, 2024 18:56

grobinson-grafana suggested changes Mar 25, 2024

View reviewed changes

th0th force-pushed the main branch from c8c0fb2 to 881c10a Compare March 25, 2024 17:00

grobinson-grafana reviewed Mar 25, 2024

View reviewed changes

grobinson-grafana mentioned this pull request Apr 17, 2024

Request: Add topic_id as an optional parameter to telegram_config #3672

Open

th0th force-pushed the main branch from 431e6da to a6bf292 Compare April 17, 2024 23:58

th0th force-pushed the main branch from d3b1725 to 7ab5ae6 Compare April 18, 2024 00:05

Merge branch 'main' into main

1f275cb

gotjosh added 2 commits April 30, 2024 10:45

In go, int32 is int by default avoid the explicit conversion.

b8668f1

Signed-off-by: gotjosh <josue.abreu@gmail.com>

Remove one more redudant reference

a5f0947

Signed-off-by: gotjosh <josue.abreu@gmail.com>

gotjosh approved these changes Apr 30, 2024

View reviewed changes

gotjosh merged commit a9b5cb4 into prometheus:main Apr 30, 2024
11 checks passed

SuperQ mentioned this pull request Oct 16, 2024

Release v0.28.0-rc.0 #4072

Merged

gillesdemey mentioned this pull request Oct 25, 2024

Alerting: Alertmanager 0.28.0 support grafana/grafana#95393

Open

8 tasks

cybercoder mentioned this pull request Nov 15, 2024

Enable setting ThreadId for Telegram notifications prometheus-operator/prometheus-operator#7122

Closed

SuperQ mentioned this pull request Dec 19, 2024

Release v0.28.0 #4176

Open

Enable setting ThreadId for Telegram notifications #3638

Enable setting ThreadId for Telegram notifications #3638

Conversation

th0th commented Dec 15, 2023 • edited Loading

yuri-tceretian commented Dec 15, 2023 • edited Loading

th0th commented Dec 15, 2023

jsDotx3 commented Dec 29, 2023

yuri-tceretian commented Jan 2, 2024

yuri-tceretian Jan 2, 2024 • edited Loading

Choose a reason for hiding this comment

raphielscape Jan 8, 2024

Choose a reason for hiding this comment

yuri-tceretian Jan 8, 2024

Choose a reason for hiding this comment

th0th Jan 31, 2024

Choose a reason for hiding this comment

asonnleitner commented Jan 31, 2024 • edited Loading

raphielscape commented Jan 31, 2024

asonnleitner commented Jan 31, 2024

cahyahikmawan commented Feb 20, 2024

TheMeier commented Mar 20, 2024

th0th commented Mar 23, 2024

grobinson-grafana commented Mar 23, 2024

th0th commented Mar 23, 2024

grobinson-grafana commented Mar 23, 2024

grobinson-grafana Mar 25, 2024

Choose a reason for hiding this comment

th0th commented Mar 25, 2024

grobinson-grafana commented Mar 25, 2024

grobinson-grafana Mar 25, 2024

Choose a reason for hiding this comment

grobinson-grafana commented Mar 25, 2024

th0th commented Mar 25, 2024

grobinson-grafana commented Mar 26, 2024

hatamiarash7 commented Apr 8, 2024

grobinson-grafana commented Apr 16, 2024

th0th commented Apr 16, 2024

th0th commented Apr 17, 2024

grobinson-grafana commented Apr 17, 2024

th0th commented Apr 18, 2024

grobinson-grafana commented Apr 23, 2024

grobinson-grafana commented Apr 30, 2024

gotjosh left a comment

Choose a reason for hiding this comment

gotjosh commented Apr 30, 2024

grobinson-grafana commented Apr 30, 2024

th0th commented Apr 30, 2024

grobinson-grafana commented Apr 30, 2024

grobinson-grafana commented Apr 30, 2024

dabelousov commented Aug 9, 2024

hatamiarash7 commented Aug 10, 2024

th0th commented Dec 15, 2023 •

edited

Loading

yuri-tceretian commented Dec 15, 2023 •

edited

Loading

yuri-tceretian Jan 2, 2024 •

edited

Loading

asonnleitner commented Jan 31, 2024 •

edited

Loading