Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms teamsv2 rendering issues #4160

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gogetdane
Copy link

Continuing on the work in #4024

Problem
Comments in #4024 and my use of the receiver indicated that the Teams card was not full width and not working on mobile.

  • Fix Teams cards are now full width
  • Fix TextBlock containing markdown is now Wrappped to prevent mobile devices rendering only the first \n in the string
  • Fix typo

mobile-renders-content Medium

full-width-card

[Documentation](https://learn.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/cards-format?tabs=adaptive-md%2Cdesktop%2Cdesktop1%2Cdesktop2%2Cconnector-html#full-width-adaptive-card)

MsTeams property must be present to render full width cards

Signed-off-by: Dane Stevens <89840555+gogetdane@users.noreply.github.com>
Signed-off-by: Dane Stevens <89840555+gogetdane@users.noreply.github.com>
Without the wrap, Teams would only render the first line on mobile which is a newline.

Signed-off-by: Dane Stevens <89840555+gogetdane@users.noreply.github.com>
@mwasson74
Copy link

I approve 😜

@gogetdane gogetdane changed the title Gogetdane/ms teamsv2 rendering issues ms teamsv2 rendering issues Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants