feat(dispatch): expose readonly interfaces #4679
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
siavashs
force-pushed
the
feat/ag-interface
branch
4 times, most recently
from
02ee92f to
f5cf518
Compare
Groups() method in dispatcher does extensive data manipulation to staisfy the API. Instead it can return a snapshot of its internal state and let the API handle the data processing. - expose readonly interfaces for AggregationGroup and Route - move Groups logic out of dispatcher and into the api handler Signed-off-by: Siavash Safi <siavash@cloudflare.com>
siavashs
force-pushed
the
feat/ag-interface
branch
from
f5cf518 to
7d3988e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups() method in dispatcher does extensive data manipulation to
staisfy the API. Instead it can return a snapshot of its internal state
and let the API handle the data processing.