Bump minimum required Go version to 1.16 #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
@mrueg, @bwplotka has asked a similar question to @mknyszek in #1031 (comment) So I'd say wait a little for answer, otherwise better to remove and simplify things. |
|
Definitely remove the logic working around that Go issue. As the comment says, it's been resolved since Go 1.15 (golang/go#19812). And, AFAICT, it really was resolved. :) |
bwplotka
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on request here by @kakkoyun #1027 (review)
@bwplotka One thing I saw was that the comment here says, this is supported since go 1.15, should we remove it as well? https://github.com/prometheus/client_golang/blob/main/prometheus/collectors/go_collector_go116.go#L45